Uh oh!
There was an error while loading. Please reload this page.
C-Libcurl client: fix enum model generation - #5604
Conversation
The "..._parseFromJSON" template was buggy because the name of the _e type used was not the same than the generated. See the first argument of "..._convertToJSON" to see that the _e type used there was not the same
Angeall
commented
Mar 16, 2020
ityuhui
commented
Mar 17, 2020
Hello @Angeall@zhemant |
ityuhui
commented
Mar 19, 2020
Hello @michelealbano Could you please take a look at this PR because it may involve your PR #5477 ? |
ityuhui
commented
Mar 21, 2020
Hi @Angeall Could you please execute ./bin/c-petstore.sh to regenerate the sample petstore and push them to this PR for reivew because it is required by RP checklist . |
Angeall
commented
Mar 23, 2020
I did, but it does not generate any change in git 😮 . |
ityuhui
commented
Mar 23, 2020
Maybe your commit is not needed by the sample petstore. |
ityuhui
commented
Mar 23, 2020
This PR unifies the enum name to {{projectName}}{{classVarName}}{{enumName}}_e after the PR #5477 It looks good to me. Please wait core team to merge. |
michelealbano
commented
Apr 7, 2020
As I discussed in my PR, my code for enums did not cover model enums. This PR appears good to me. |
wing328
commented
Aug 17, 2020
CI failure (fixed in the master) not related to this PR. |
Completes commit fc9d458
The "..._parseFromJSON" template was buggy because the name of the _e type used was not the same than the generated.
See the first argument of "..._convertToJSON" to see that the _e type used there was not the same
About #5477 (#5091 and #4293)
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.