[Kotlin][Client] Added supporting Retrofit2(RxJava/RxJava2/Coroutines)

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.

[kuFEAR]

Added supporting Retrofit2(RxJava/RxJava2/Coroutines) for Kotlin client code generator

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project before.
• Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
• File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@jimschubert@dr4ke616@karismann@Zomzog@andrewemery@4brunu

[wing328]

Please merge the latest master into this branch to resolve the CircleCI failure.

[kuFEAR]

hm, merge is not helped

[kuFEAR]

Looks like broken for generics somewhere before my changes

[4brunu]

Currently we have two open PR that implement coroutines support.
#5697
@wing328 could you please help with this? How should we handle this?

[kuFEAR]

#5600 Fixed encoding from 3. using {{{parent}}}

[kuFEAR]

3. [FIXED]
   I fixed adding empty braces for inheritance from map/array by {{#isMapModel}}(){{/isMapModel}}{{#isArrayModel}}(){{/isArrayModel}}, I don't know is correct approach or not, but it works)

[4brunu]

@kuFEAR Why did you remove gson from here?

[kuFEAR]

#5750 (comment) 1.

[kuFEAR]

Gson @SerializedName target only for method and fields
@target({ElementType.FIELD, ElementType.METHOD}) and Kotlin interface fields is not yet determined as field by kotlin compiler, I saw error message there

[4brunu]

Thanks

[4brunu]

@kuFEAR same here

[kuFEAR]

#5750 (comment) 1.

[4brunu]

Thanks

[kuFEAR]

I have an idea add @get:SerializedName("field")

[4brunu]

If that works, it would be nice, because I use Gson on my projects

[kuFEAR]

+

[4brunu]

Thanks

[kuFEAR]

[main] ERROR org.openapitools.codegen.languages.MysqlSchemaCodegen - Invalid database name. '12345' cannot be used as MySQL identifier. Escaped value '12345_db' will be used instead.
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - ERROR! Not handling class QueryParameter {
class Parameter {
name: limit
in: null
description: this is a description
required: true
deprecated: null
allowEmptyValue: null
style: null
explode: null
allowReserved: null
schema: null
examples: null
example: null
content: null
$ref: null
}
in: query
} as Body Parameter at the moment
[main] ERROR org.openapitools.codegen.DefaultCodegen - `null` (map property) does not have a proper inner type defined. Default to type:string
[main] ERROR org.openapitools.codegen.DefaultCodegen - body in fromRequestBody cannot be null!
[main] ERROR org.openapitools.codegen.utils.ModelUtils - Schema cannot be null in isFreeFormObject check
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]
[main] ERROR o.o.c.config.CodegenConfigurator - Unexpected character ('-' (code 45)) in numeric value: expected digit (0-9) to follow minus sign, for valid numeric value
at [Source: (File); line: 1, column: 3]

[ERROR] Failed to execute goal org.codehaus.mojo:exec-maven-plugin:1.2.1:exec (test) on project PythonFlaskConnexionTests: Command execution failed. Process exited with an error: 2 (Exit value: 2) -> [Help 1]
[ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
[ERROR] [ERROR] After correcting the problems, you can resume the build with the command
[ERROR] mvn <args> -rf :PythonFlaskConnexionTests

This error is related to my PR?

[4brunu]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

[kuFEAR]

I don't think so, it seems to be related to python, and the master branch was failing with the same error.

ok, thanks

[wing328]

The issue has been fixed in the master. Please merge the latest master into this branch to fix the issue.

[kuFEAR]

now it fails on sudo apt-get install elixir

[wing328]

Restarted the CI job. Let's see how it goes.

[wing328]

Tested the kotlin retrofit2 samples and no longer encounter the issue.