Implement Asp.Net Core 3.0/3.1 generator (#6009) by phatcher · Pull Request #6025 · OpenAPITools/openapi-generator

phatcher · 2020-04-23T09:58:15Z

Addresses #6009, mainly new templates but some minor changes to the aspnetcore generator:

Fixed some issues with the 2.x templates which meant the resulting code did not compile.
Improve reporting, i.e. code shows correct .Net Core version
Introduced new templates for 3.x using idiomatic Asp.Net Core 3.
Change default startup to show the swagger definition rather than a non-existent page.
Improved the Docker file so that we can integrate into Visual Studio docker generation; not running under Docker at the moment

PR checklist

Read the contribution guidelines.
If contributing template-only or documentation-only changes which will change sample output, build the project before.
Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
Copy the technical committee to review the pull request if your PR is targeting a particular programming language. @jimschubert, @frankyjuang, @shibayan

…tion

phatcher · 2020-04-24T17:27:52Z

The build failures don't appear to be anything to do with the code changes, do I need to base this off a different commit?

wing328 · 2020-04-27T15:45:48Z

I've updated the documentation via fff4da9. Let's see how it goes.

wing328 · 2020-04-27T15:47:08Z

cc @A-Joshi as well.

phatcher · 2020-04-28T07:43:10Z

Seems like the Swift4 tests are the culprit now

shibayan

I would like it to be generated so that the code is like to the template of ASP.NET Core 3.x.

shibayan · 2020-04-28T13:54:36Z

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="utf-8"?>


Please delete this file.

Should I remove the entire www directory as that's not part of the template anymore?

Yes. It should be fine to remove it.

…artup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp>

wing328 · 2020-05-01T14:40:21Z

If no further feedback, I'll merge this over the weekend.

shibayan · 2020-05-02T13:59:18Z

Please wait for the merge until web.config under wwwroot is removed. That setting is harmful.

wing328 · 2020-05-02T14:57:10Z

@shibayan no worry. I'll remove it after merging the PR into master

wing328 · 2020-05-03T12:48:04Z

Filed #6147 to skip web.config generation.

wing328 · 2020-05-05T04:17:54Z

To promote the new enhancement:

wing328 · 2020-05-07T03:59:40Z

@phatcher thanks for the PR, which has been included in the v4.3.1 release: https://twitter.com/oas_generator/status/1258057660974329861

…Tools#6025) * Minor changes to 2.1 templates to make them work or improve documentation * Support for ASP.NET Core 3.0 and 3.1 * Update aspnetcore test scripts and results * Update generated documentation * update doc * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp> * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp> Co-authored-by: William Cheng <wing328hk@gmail.com> Co-authored-by: Tatsuro Shibamura <me@shibayan.jp>

…-5.0 * origin/master: (78 commits) [powershell-experimental] : http signature authentication implementation (#6176) Add missing AnyType type mapping (#6196) remove pubspec.lock (#6208) Minor fixes post-release (#6204) [cpp][Qt5] Add the ability to pass QNetworkAccessManager as a parameter (#6053) comment out dart2 test due to failure adds the missing typeMapping for AnyType (#6199) [Rust Server] Support boolean headers, and fix panic handling headers (#6056) update samples update 5.0.0 release date update readme with new release Prepare 4.3.1 release (#6187) Fix#6157: Updated native template to fix null async return (#6168) Show description when summary is missing (#6159) Make the array items optional (#6132) [aspnetcore] test petstore samples in drone.io (#6148) fix bearer auth in c# netcore async call (#6136) skip web.config for aspnetcore 3.x (#6147) Adds memoization and deserialization through 2 or more discriminators (#6124) Implement Asp.Net Core 3.0/3.1 generator (#6009) (#6025) ...

…Tools#6025) * Minor changes to 2.1 templates to make them work or improve documentation * Support for ASP.NET Core 3.0 and 3.1 * Update aspnetcore test scripts and results * Update generated documentation * update doc * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp> * Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/Startup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp> Co-authored-by: William Cheng <wing328hk@gmail.com> Co-authored-by: Tatsuro Shibamura <me@shibayan.jp>

phatcher added 4 commits April 22, 2020 21:33

Minor changes to 2.1 templates to make them work or improve documenta…
1a89e35
…tion

Support for ASP.NET Core 3.0 and 3.1
71f4ab9

Update aspnetcore test scripts and results
1c0e6ac

Update generated documentation
11ad8b2

wing328 added Enhancement: Compatibility Server: C-Sharp labels Apr 24, 2020

update doc
fff4da9

shibayan suggested changes Apr 28, 2020
View reviewed changes

phatcherand others added 2 commits April 28, 2020 20:06

Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/St…
98cd254
…artup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp>

Update modules/openapi-generator/src/main/resources/aspnetcore/3.0/St…
14aa039
…artup.mustache Co-Authored-By: Tatsuro Shibamura <me@shibayan.jp>

wing328 reviewed May 1, 2020
View reviewed changes

Comment threadmodules/openapi-generator/src/main/resources/aspnetcore/2.1/Startup.mustache

wing328 added this to the 4.3.1 milestone May 1, 2020

phatcher mentioned this pull request May 1, 2020
[OpenAPI] Allow configuration of where to pull openapi-generator from eclipse-archived/codewind#2746
Open

wing328 merged commit e4cbaa7 into OpenAPITools:masterMay 3, 2020

wing328 mentioned this pull request May 3, 2020
Skip web.config generation for aspnetcore 3.x #6147
Merged
5 tasks

Uh oh!

Uh oh!

Conversation

phatcher commented Apr 23, 2020

PR checklist

Uh oh!

phatcher commented Apr 24, 2020

Uh oh!

wing328 commented Apr 27, 2020

Uh oh!

wing328 commented Apr 27, 2020

Uh oh!

phatcher commented Apr 28, 2020

Uh oh!

shibayan left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

shibayanApr 28, 2020

Choose a reason for hiding this comment

Uh oh!

phatcherApr 28, 2020

Choose a reason for hiding this comment

Uh oh!

shibayanApr 29, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wing328 commented May 1, 2020

Uh oh!

shibayan commented May 2, 2020

Uh oh!

wing328 commented May 2, 2020

Uh oh!

wing328 commented May 3, 2020

Uh oh!

wing328 commented May 5, 2020

Uh oh!

wing328 commented May 7, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants