Skip to content

[Java][MicroProfile] Use jsonb imports for serializing and deserializing enum - #6064

Merged
wing328 merged 2 commits into
OpenAPITools:masterfrom
Ravisankar-Challa:microprofile_jaxb_imports
Jun 17, 2020
Merged

[Java][MicroProfile] Use jsonb imports for serializing and deserializing enum#6064
wing328 merged 2 commits into
OpenAPITools:masterfrom
Ravisankar-Challa:microprofile_jaxb_imports

Conversation

@Ravisankar-Challa

Copy link
Copy Markdown
Contributor

Fixes the issue no: 2 reported in the issue #6028

The pull request removes all jaxb (xml) imports when withXml=false also it uses JsonbTypeSerializer & JsonbTypeDeserializer to deal with enum data types.

@Ravisankar-Challa
Ravisankar-Challaforce-pushed the microprofile_jaxb_imports branch 3 times, most recently from cab7830 to 5b375bbCompareApril 28, 2020 07:03
@Ravisankar-ChallaRavisankar-Challa changed the title Use jsonb imports for serializing and deserializing pojoUse jsonb imports for serializing and deserializing enumApr 29, 2020
@wing328

Copy link
Copy Markdown
Member

@Ravisankar-Challa thanks for the PR. I did a test with petstore and withXml set to true but got the following error messages (partial):

[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Order.java:[213,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Order
[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Pet.java:[108,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Pet
[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Pet.java:[129,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Pet
[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Pet.java:[150,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Pet
[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Pet.java:[171,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Pet
[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Pet.java:[197,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Pet
[ERROR] /private/tmp/microprofile/src/main/java/org/openapitools/client/model/Pet.java:[223,4] cannot find symbol
[ERROR] symbol: class JsonbProperty
[ERROR] location: class org.openapitools.client.model.Pet
[ERROR] -> [Help 1]

I wonder if you can take a look when you've time.

@Ravisankar-Challa

Ravisankar-Challa commented Jun 16, 2020

Copy link
Copy Markdown
ContributorAuthor

@wing328 I have fixed the issue related to withXml=true. I am able to successfully run ./bin/run-all-petstore in local. But it is failing in CI with error ./bin/run-all-petstore not found. Can you please take a look. https://cloud.drone.io/OpenAPITools/openapi-generator/9162

@wing328

Copy link
Copy Markdown
Member

Please merge the latest master into your branch as we've introduced a new way to update the sample:

https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-the-samples-i-couldnt-find-the-script-under-bin-or-windows-batch-files-under-binwindows

@wing328wing328 added this to the 5.0.0 milestone Jun 16, 2020
@wing328wing328 changed the title Use jsonb imports for serializing and deserializing enum[Java][MicroProfile] Use jsonb imports for serializing and deserializing enumJun 16, 2020
@Ravisankar-Challa
Ravisankar-Challaforce-pushed the microprofile_jaxb_imports branch from 317f4a3 to d36ccf6CompareJune 17, 2020 04:54
@Ravisankar-Challa

Ravisankar-Challa commented Jun 17, 2020

Copy link
Copy Markdown
ContributorAuthor

@wing328 I have done rebase on master branch. Now the build is successful.
I am trying to fix the issue #6028
Which has 2 more pull requests could you please verify them as well please.
https://github.com/OpenAPITools/openapi-generator/pull/6062/files
https://github.com/OpenAPITools/openapi-generator/pull/6680/files

@wing328

Copy link
Copy Markdown
Member

Tested with both withXml set to true, false and both are compiling fine without issues.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@Ravisankar-Challa@wing328