Uh oh!
There was an error while loading. Please reload this page.
[kotlin][spring] Fix ApiUtil compilation - #6084
Merged
jimschubert merged 2 commits intoJun 5, 2020
Merged
Conversation
sylvainmoindron
commented
Apr 28, 2020
ContributorAuthor
adding technical committe @jimschubert , @dr4ke616@karismann@Zomzog@andrewemery@4brunu @yutaka0m |
| @@ -12,9 +12,9 @@ object ApiUtil { | |||
| fun setExampleResponse(req: NativeWebRequest, contentType: String, example: String) { | |||
| try { | |||
| val res = req.getNativeResponse(HttpServletResponse::class.java) | |||
Contributor
There was a problem hiding this comment.
Suggested change
| val res = req.getNativeResponse(HttpServletResponse::class.java) | |
| val res: HttpServletResponse? = req.getNativeResponse(HttpServletResponse::class.java) |
ContributorAuthor
There was a problem hiding this comment.
If
resis nullable, how about declareHttpServletResponse??
kotlin infer itself that res is of type HttpServletResponse? that's why res.setCharacterEncoding doesn't compile in the original bug.
(in the spring librairie getNativeResponse is annotated by @Nullable)
inadysensei
left a comment
Contributor
There was a problem hiding this comment.
If res is nullable, how about declare HttpServletResponse? ?
inadysensei
approved these changes
May 3, 2020
inadysensei
left a comment
Contributor
There was a problem hiding this comment.
I can understand.
LGTM 👍
jimschubert
approved these changes
Jun 5, 2020
jimschubert
left a comment
Member
There was a problem hiding this comment.
Looks good. Sorry for the delay in review (been very busy).
I'll rebuild samples locally, and if there are changes I'll push them up before merge.
jimschubert added a commit
that referenced
this pull request
Jun 5, 2020
* master: (345 commits) [kotlin][spring] Fix ApiUtil compilation (#6084) update python samples [Python] Fixed docstrings in api.mustache (#6391) [BUG][python] Support named arrays (#6493) [Go] whitelist AdditionalProperties in the field name (#6543) [kotlin][client] remove tabs usage (#6526) [PS] automatically derive discriminator mapping for oneOf/anyOf (#6542) [C++][Ue4] various bus fixes (#6539) Fix incorrect npx command (#6537) update pester to 5.x (#6536) comment out openapi3 java jersey2-java8 tests add additional properties support to powershell client generator (#6528) [Go][Experimental] Support additionalProperties (#6525) #5476 [kotlin] [spring] fix swagger and spring annotation for defaultValue (#6101) [samples] regenerate (#6533) [python] Fix date-time parsing (#6458) Register OAuth2ClientContext as bean (#6172) [Go][Experimental] Fix discriminator lookup (#6521) Typescript-rxjs: print param name (#6368) add oneof discrimistrator lookup to go experimental (#6517) ...
jimschubert added a commit
that referenced
this pull request
Jun 6, 2020
* master: Fix typescript generator for parameter collectionFormat for pipes ssv (#6553) [C++][Pistache] Catch HttpError from user-provided handler (#6520) remove scala related profile from the pom (#6554) move ruby tests to travis (#6555) [Java][jersey2] fix cast error for default value in DateTimeOffset object (#6547) [Swift] fix GET request with array parameter (#6549) [kotlin][spring] Fix ApiUtil compilation (#6084) update python samples [Python] Fixed docstrings in api.mustache (#6391) [BUG][python] Support named arrays (#6493) [Go] whitelist AdditionalProperties in the field name (#6543) [kotlin][client] remove tabs usage (#6526) [PS] automatically derive discriminator mapping for oneOf/anyOf (#6542) [C++][Ue4] various bus fixes (#6539) Fix incorrect npx command (#6537) update pester to 5.x (#6536) comment out openapi3 java jersey2-java8 tests add additional properties support to powershell client generator (#6528) [Go][Experimental] Support additionalProperties (#6525) #5476 [kotlin] [spring] fix swagger and spring annotation for defaultValue (#6101)
This was referenced Dec 27, 2023
This was referenced Dec 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes#5476 The kotlin-spring generator ApiUtil object doesn't compile, by adding null safe accessor
PR checklist
./bin/(or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run./bin/{LANG}-petstore.sh,./bin/openapi3/{LANG}-petstore.shif updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).master,4.3.x,5.0.x. Default:master.