') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Mark swift4 generator as deprecated by wing328 · Pull Request #6311 · OpenAPITools/openapi-generator · GitHub
Skip to content

Mark swift4 generator as deprecated - #6311

Merged
wing328 merged 2 commits into
masterfrom
swift4-deprecated
May 15, 2020
Merged

Mark swift4 generator as deprecated#6311
wing328 merged 2 commits into
masterfrom
swift4-deprecated

Conversation

@wing328

@wing328wing328 commented May 15, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Mark swift4 generator as deprecated

swift4 generator will be removed in the 5.x release.

cc @jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328wing328 added this to the 5.0.0 milestone May 15, 2020
@4brunu

4brunu commented May 15, 2020

Copy link
Copy Markdown
Contributor

Looks good to me.
But I propose that we also remove the files inside bin/ and samples/ related to Swift, Swift2 and Swift3.
Or do you prefer to do that in a separated PR?

@wing328

wing328 commented May 15, 2020

Copy link
Copy Markdown
MemberAuthor

Or do you prefer to do that in a separated PR?

Yes.

@4brunu

4brunu commented May 15, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

So This PR looks good to me for merge.
Do you want to remove the old samples related to old versions of swift or should I do it?

@wing328

wing328 commented May 15, 2020

Copy link
Copy Markdown
MemberAuthor

Do you want to remove the old samples related to old versions of swift or should I do it?

I'll do it later.

@wing328
wing328 merged commit 26830bf into masterMay 15, 2020
jimschubert added a commit that referenced this pull request May 16, 2020
@jimschubert
Merge branch 'master' into file-tracking
2ff34b5
* master:
Update username (arun-nalla) (#6319)
[typescript-axios] Implement useSingleRequestParameter option (#6288)
[typescript] Remove "v4-compat" value of enumSuffix (#6308)
Mark swift4 generator as deprecated (#6311)
Remove @nickmeinhold from Dart technical committee (#6309)
Migrate Erlang samples to use OAS 3 spec (#6297)
update dart samples
Improve parameter documentation (#6092)
Minor improvements to `plantuml` doc generator (#6298)
undo changes to petstore.yaml oas3.0 (#6299)
Allow passing progress callbacks through client methods. (#6261)
Create method to json (#6111)
@wing328
wing328 deleted the swift4-deprecated branch May 26, 2020 13:50
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Client: SwiftDecommission

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@wing328@4brunu