[dart] better date format - #6389

Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom
wbt-solutions:date-format-dart
Aug 21, 2020
Merged

[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom
wbt-solutions:date-format-dart

Conversation

@sbu-WBT

@sbu-WBTsbu-WBT commented May 21, 2020

Copy link
Copy Markdown
Contributor

Fixes#2696

If something is missing or other changes have to be done, I'm open for any suggestions.

I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat

@ircecho @swipesight @jaumard @athornz @amondnet

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@sbu-WBT

sbu-WBT commented Jun 11, 2020

Copy link
Copy Markdown
ContributorAuthor

Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328

@wing328wing328 added this to the 5.0.0 milestone Jun 15, 2020
@agilob

agilob commented Jul 21, 2020

Copy link
Copy Markdown
Contributor

LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart

@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328

wing328 commented Jul 26, 2020

Copy link
Copy Markdown
Member

I'll take a look in the coming week.

wing328
wing328 reviewed Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache Outdated
part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');

@wing328wing328Aug 8, 2020•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?

@sbu-WBTsbu-WBTAug 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it

@wing328wing328Aug 8, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100

@sbu-WBTsbu-WBTAug 8, 2020

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final

@sbu-WBT

sbu-WBT commented Aug 9, 2020

Copy link
Copy Markdown
ContributorAuthor

Everything is fine now, isn't it? @wing328

@wing328
wing328 merged commit f0fd2cb into OpenAPITools:masterAug 21, 2020
@wing328

wing328 commented Aug 21, 2020

Copy link
Copy Markdown
Member

@sbu-WBT PR merged. Thanks for your contribution.

@wing328wing328 changed the title Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT deleted the date-format-dart branch August 21, 2020 08:27
jimschubert added a commit that referenced this pull request Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit to mohamedelhabib/openapi-generator that referenced this pull request Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1 mentioned this pull request Apr 14, 2024
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees

No one assigned

Labels

Client: DartIssue: Bug

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string

4 participants

@sbu-WBT@agilob@wing328@SimonIT
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[dart] better date format - #6389
Merged
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Aug 21, 2020
Merged
[dart] better date format#6389
wing328 merged 8 commits into
OpenAPITools:masterfrom 
wbt-solutions:date-format-dart
Conversation
@sbu-WBT
@sbu-WBTsbu-WBT
commented
May 21, 2020

Copy link


Copy Markdown

Contributor
Fixes#2696
If something is missing or other changes have to be done, I'm open for any suggestions.
I'm not sure if the petstore changes are correct. I executed all commands from dart-petstore.bat
@ircecho @swipesight @jaumard @athornz @amondnet
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project before.
  •  Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  •  File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
@sbu-WBT
sbu-WBT
commented
Jun 11, 2020

Copy link


Copy Markdown

ContributorAuthor
Guys, I don't know why the CI builds fail. I re-updated the samples with the new instructions. I used the git bash on windows to run generate-samples.sh. It seams, that on windows backslashes and else forward slashes are used. I really need this fix so I would appreciate any help. @wing328
@wing328wing328
added this to the 5.0.0 milestone
Jun 15, 2020
@agilob
agilob
commented
Jul 21, 2020

Copy link


Copy Markdown

Contributor
LGTM but would like to see a test for it samples/client/petstore/dart2/petstore/test/store_faked_client_test.dart
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
1ec4eb2
@sbu-WBT
Merge remote-tracking branch 'upstream/master' into date-format-dart
79b193f
# Conflicts:
#	modules/openapi-generator/src/main/resources/dart2/apilib.mustache
#	modules/openapi-generator/src/main/resources/dart2/pubspec.mustache
#	samples/client/petstore/dart2/petstore_client_lib/lib/api.dart
#	samples/client/petstore/dart2/petstore_client_lib/pubspec.yaml
@wing328
wing328
commented
Jul 26, 2020

Copy link


Copy Markdown

Member
I'll take a look in the coming week.
wing328
wing328
reviewed
Aug 8, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/dart2/api_helper.mustache
Outdated

part of {{pubName}}.api;

const _delimiters = const {'csv': ',', 'ssv': ' ', 'tsv': '\t', 'pipes': '|'};
final _dateFormatter = DateFormat('yyyy-MM-dd');
@wing328wing328Aug 8, 2020•

edited

Loading

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am I understanding it correctly that _dateFormatter cannot be changed to other date formats during runtime? Shall we make it configurable at runtime?
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My thoughts were to protect it against accidentally change. I don't see any reasons to allow modification as the specification says it hast to be this format https://swagger.io/specification/#dataTypes. But if you wish, I can change it
@wing328wing328Aug 8, 2020

Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, all REST API should be using the date format following RFC3339 according to OpenAPI spec but there were use cases before in which date using a different format and that's why we make it configurable, e.g. C# configuration class: https://github.com/OpenAPITools/openapi-generator/blob/master/samples/client/petstore/csharp/OpenAPIClient/src/Org.OpenAPITools/Client/Configuration.cs#L100
@sbu-WBTsbu-WBTAug 8, 2020

Copy link


Copy Markdown

ContributorAuthor
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I will remove the final
@sbu-WBT
sbu-WBT
commented
Aug 9, 2020

Copy link


Copy Markdown

ContributorAuthor
Everything is fine now, isn't it? @wing328
@wing328
wing328
merged commit f0fd2cb
into
OpenAPITools:masterAug 21, 2020
@wing328
wing328
commented
Aug 21, 2020

Copy link


Copy Markdown

Member
@sbu-WBT PR merged. Thanks for your contribution.
@wing328wing328
changed the title
Date format dart[dart] better date formatAug 21, 2020
@sbu-WBT
sbu-WBT
deleted the

date-format-dart

branch
August 21, 2020 08:27
jimschubert added a commit
that referenced
this pull request
Aug 23, 2020
@jimschubert
Merge branch 'master' into addl-props-import
1faa26f
* master: (720 commits)
[docs] Update README badges (#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue #7258 fix (#7259)
[Dart] Get all enum values in a list (#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (#7273)
[core][bug] FILES is now path relative with no prefixes (#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (#7268)
[Java][jersey2] Add jersey injection dependencies (#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (#7255)
Date format dart (#6389)
minor enhancement to java client generator (#7253)
typescript: Fix Union Types Import Issue (#6789)
Modifying the es5 and es6 templates for javascript to handle default values (#6649)
[python-exp] simplify examples (#7157)
Support for KumuluzEE microprofile runtime (#5944)
[C#][netcore] minor improvements and bug fixes (#7244)
Deprecate Flash (ActionScript) client generator (#7231)
...
jimschubert added a commit
to mohamedelhabib/openapi-generator
that referenced
this pull request
Aug 24, 2020
@jimschubert
Merge branch 'master' into fix-double-slash-into-markdown-models-links
3219ef8
* master: (219 commits)
[java] Appropriate instantiation of model with dynamic properties (OpenAPITools#6052)
[docs] Update README badges (OpenAPITools#7276)
Update apiInvoker.mustache and sample file for akka-scala client for issue OpenAPITools#7258 fix (OpenAPITools#7259)
[Dart] Get all enum values in a list (OpenAPITools#7166)
Update .gitattributes
[ci] Set ubuntu workflow verification to autoclrf=true, safeclrf=false
Update check-supported-versions.yaml
[ci] Update gitattributes and allow skipping docs generation for Windows CI workflows (OpenAPITools#7273)
[core][bug] FILES is now path relative with no prefixes (OpenAPITools#7271)
Update check-supported-versions.yaml
Update check-supported-versions.yaml (OpenAPITools#7268)
[Java][jersey2] Add jersey injection dependencies (OpenAPITools#7240)
[C][Clang Static Analyzer] Remove the useless variable when assembling URL (OpenAPITools#7255)
Date format dart (OpenAPITools#6389)
minor enhancement to java client generator (OpenAPITools#7253)
typescript: Fix Union Types Import Issue (OpenAPITools#6789)
Modifying the es5 and es6 templates for javascript to handle default values (OpenAPITools#6649)
[python-exp] simplify examples (OpenAPITools#7157)
Support for KumuluzEE microprofile runtime (OpenAPITools#5944)
[C#][netcore] minor improvements and bug fixes (OpenAPITools#7244)
...
@evanholt1evanholt1
mentioned this pull request
Apr 14, 2024

Open

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@wing328wing328wing328 left review comments

Assignees


No one assigned


Labels

Client: DartIssue: Bug

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[BUG] Dart code generator does not support date format for string


4 participants

@sbu-WBT@agilob@wing328@SimonIT