Skip to content

[PS] Refactor the http signing auth with ecdsa support - #6397

Merged
wing328 merged 23 commits into
OpenAPITools:masterfrom
Ghufz:master
May 29, 2020
Merged

[PS] Refactor the http signing auth with ecdsa support#6397
wing328 merged 23 commits into
OpenAPITools:masterfrom
Ghufz:master

Conversation

@Ghufz

@GhufzGhufz commented May 22, 2020•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR has following changes

  1. User can configure the httpsigning configuration using the cmdlet Set-ConfigurationHttpSigning
  2. ECDSA support for powershell 7 and above
  3. RSA key signature mode RSASSA-PSS supported on powershell 7 and above

Example :
Set-Configuration -BaseUrl <<>>
Set-ConfigurationHttpSigning -KeyId <> KeyFilePath <>

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project before.
  • Run the shell script(s) under ./bin/ (or Windows batch scripts under.\bin\windows) to update Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit, and these must match the expectations made by your contribution. You only need to run ./bin/{LANG}-petstore.sh, ./bin/openapi3/{LANG}-petstore.sh if updating the code or mustache templates for a language ({LANG}) (e.g. php, ruby, python, etc).
  • File the PR against the correct branch: master, 4.3.x, 5.0.x. Default: master.
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
sebastien-rosset
sebastien-rosset reviewed May 22, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/configuration.mustache Outdated
@wing328wing328 changed the title Refator the http signing auth with ecdsa support[PS] Refactor the http signing auth with ecdsa supportMay 25, 2020
Ghufzand others added 9 commits May 26, 2020 11:53
@Ghufz
Merge remote-tracking branch 'upstream/master'
206be22
@Ghufz@sebastien-rosset
Update modules/openapi-generator/src/main/resources/powershell/config…
7c67a2a
…uration.mustache
Co-authored-by: Sebastien Rosset <serosset@cisco.com>
@Ghufz@sebastien-rosset
Update modules/openapi-generator/src/main/resources/powershell/config…
c1f19a2
…uration.mustache
Co-authored-by: Sebastien Rosset <serosset@cisco.com>
@Ghufz@sebastien-rosset
Update modules/openapi-generator/src/main/resources/powershell/config…
1381f3b
…uration.mustache
Co-authored-by: Sebastien Rosset <serosset@cisco.com>
@Ghufz@sebastien-rosset
Update modules/openapi-generator/src/main/resources/powershell/config…
83e81bc
…uration.mustache
Co-authored-by: Sebastien Rosset <serosset@cisco.com>
@Ghufz@sebastien-rosset
Update modules/openapi-generator/src/main/resources/powershell/config…
dd6d0b5
…uration.mustache
Co-authored-by: Sebastien Rosset <serosset@cisco.com>
@Ghufz
HttpSigningHeader accepts any header available in request to calculat…
984f77f
…e the signature.
@Ghufz
Merge branch 'master' of github.com:Ghufz/openapi-generator
c8676f5
@Ghufz@sebastien-rosset
Update modules/openapi-generator/src/main/resources/powershell/http_s…
e954b4f
…ignature_auth.mustache
Co-authored-by: Sebastien Rosset <serosset@cisco.com>
@sebastien-rosset

sebastien-rosset commented May 26, 2020

Copy link
Copy Markdown
Contributor

LGTM

wing328
wing328 reviewed May 27, 2020
View reviewed changes
Comment threadmodules/openapi-generator/src/main/resources/powershell/api_client.mustache Outdated
@Ghufz
Ghufz requested a review from wing328May 27, 2020 06:33
@wing328

wing328 commented May 28, 2020

Copy link
Copy Markdown
Member

The appveyor failure (due to new major version release of pester) has been fixed in the master. Please merge the latest master into this branch to resolve it.

I would also recommend create a new branch for PR moving forward.

@wing328
wing328 merged commit 8480706 into OpenAPITools:masterMay 29, 2020
jimschubert added a commit to jimschubert/openapi-generator that referenced this pull request May 30, 2020
@jimschubert
Merge branch 'master' into cleanup-template-management
5166440
* master:
[PS] Refactor the http signing auth with ecdsa support (OpenAPITools#6397)
[Rust Server] Hyper 0.13 + Async/Await support (OpenAPITools#6244)
[Rust] set supportAsync to true as the default (OpenAPITools#6480)
[php-symfony] Set required PHP version ^7.1.3 (OpenAPITools#6181)
update doc
[csharp] Rename netstandard to netstandard1.3 (OpenAPITools#6460)
feat: support deprecated parameters for typescript-axios generator (OpenAPITools#6475)
[REQ][typescript-axios] useSingleRequestParameter should mark parameter optional if all properties are optional (OpenAPITools#6477)
better struct alias in rust (OpenAPITools#6470)
Migrate Go server samples to OAS 3 only (OpenAPITools#6471)
[Rust][reqwest] add async support (OpenAPITools#6464)
[codegen][python-experimental] Composed schema with additionalProperties (OpenAPITools#6290)
[Java] Decommission Retrofit 1.x support (OpenAPITools#6447)
remove scala oas3 samples (OpenAPITools#6446)
[Java][jersey2] Fix RuntimeException when HTTP signature parameters are not configured (OpenAPITools#6457)
[Java][jersey2] Improve http signature code comments (OpenAPITools#6463)
[typescript-angular] drop support of angular below 6.0.0 (OpenAPITools#6360)
[cli] new 'author template' command (OpenAPITools#6441)
python-experimental updates ancestor + adds descendant discriminator tests (OpenAPITools#6417)
jimschubert added a commit that referenced this pull request May 30, 2020
@jimschubert
Merge branch 'master' into remove-deprecations-5.0
54826e2
* master: (36 commits)
Improve handling spaces in example command (#6482)
fix maven plugin snapshot version
comment out erlang server test (#6499)
Migrate Perl samples to use OAS v3 spec (#6490)
[core] Refactor templating management (#6357)
migrate apex samples to use oas3 spec (#6488)
add new file in php-symfony sample
[PS] Refactor the http signing auth with ecdsa support (#6397)
[Rust Server] Hyper 0.13 + Async/Await support (#6244)
[Rust] set supportAsync to true as the default (#6480)
[php-symfony] Set required PHP version ^7.1.3 (#6181)
update doc
[csharp] Rename netstandard to netstandard1.3 (#6460)
feat: support deprecated parameters for typescript-axios generator (#6475)
[REQ][typescript-axios] useSingleRequestParameter should mark parameter optional if all properties are optional (#6477)
better struct alias in rust (#6470)
Migrate Go server samples to OAS 3 only (#6471)
[Rust][reqwest] add async support (#6464)
[codegen][python-experimental] Composed schema with additionalProperties (#6290)
[Java] Decommission Retrofit 1.x support (#6447)
...
@wing328wing328 added this to the 5.0.0 milestone Jul 3, 2020
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wing328wing328Awaiting requested review from wing328
1 more reviewer
@sebastien-rossetsebastien-rossetsebastien-rosset left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Client: PowerShellEnhancement: Security

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@Ghufz@sebastien-rosset@wing328