[Java] Test simple oneOf model

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another

[jirikuncar]

Extracts a test for oneOf model for Java Jersey2 from #6674.

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

[wing328]

What about adding the spec (oneOfOverlapingTypes.yaml) to the existing one used by Java (jersey2) client generator?

[spacether]

Can you make the color property required in both apple and banana?
Some languages treat required and optional variables differently, and making it required makes it required at the composed schema level also.

Also another corner case is:

AppleOptionalColor: color is optional
BananaRequiredColor: color is required
ComposedConfusedColor:
oneOf:
- AppleOptionalColor
- BananaRequiredColor

My understanding is that color may appear both as a required and optional property in the composed schema ComposedConfusedColor :(
@sebastien-rosset
@wing328
@jimschubert

[wing328]

Just to add that the Fruit definition seems to be invalid with respect to how oneOf is defined.

Consider {"color":"green"} which will match both Apple and Banana and result in the violation of the oneOf definition (one and only one match)

[jirikuncar]

@wing328{"color":"green"} this is the whole point! There is an overlap in a single field but you need other fields to determine the right model.

[wing328]

Then those other fields need to be required instead. Otherwise, {"color":"green"} will match both.

[spacether]

So is the point of adding these tests to show differences in enum values or in the data type of the property?
My understanding was that the data type of the property was the bigger issue.
For example having:

• color be string in one model
• color be integer in another