[typescript-axios] switched to new URL API

[sapphi-red]

Switched to new URL API since Node.js legacy URL API is deprecated.

This will drop support Node.js below v6.0.0 (which was released Apr. 2016).

close#6859

PR checklist

• Read the contribution guidelines.
• If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
• Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
• File the PR against the correct branch: master
• Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

[macjohnny]

LGTM

[macjohnny]

thanks for your contribution

[sapphi-red]

@macjohnny
I found that this PR drops not only below v6 but below v10.
I overlooked the document that URL is not a global object until v10.
Since Node.js v7 to v9 is already EOL, I think this is not a serious problem.

[macjohnny]

Thanks for the update

[breezewish]

This PR introduces a bug that const query = new URLSearchParams(localVarUrlObj.search); will produce a constant re-define syntax error when there is already a API parameter called query (in the function arguments).

[macjohnny]

@breeswish this could be fixed by renaming query to queryParameters, as queryParameters is in the list of the reserved words:

openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractTypeScriptClientCodegen.java

Lines 111 to 116 in 6909c88

	reservedWords.addAll(Arrays.asList(
	// local variable names used in API methods (endpoints)
	"varLocalPath", "queryParameters", "headerParams", "formParams", "useFormData", "varLocalDeferred",
	"requestOptions",
	// Typescript reserved words
	"abstract", "await", "boolean", "break", "byte", "case", "catch", "char", "class", "const", "continue", "debugger", "default", "delete", "do", "double", "else", "enum", "export", "extends", "false", "final", "finally", "float", "for", "function", "goto", "if", "implements", "import", "in", "instanceof", "int", "interface", "let", "long", "native", "new", "null", "package", "private", "protected", "public", "return", "short", "static", "super", "switch", "synchronized", "this", "throw", "transient", "true", "try", "typeof", "var", "void", "volatile", "while", "with", "yield"));

would you like to fix this?

[sapphi-red]

I have made a PR #7475.

[baurine]

Hi, it seems the above PR #7475 is not contained in the latest 5.0.0-beta2: https://github.com/OpenAPITools/openapi-generator/blob/v5.0.0-beta2/modules/openapi-generator/src/main/resources/typescript-axios/apiInner.mustache#L191

[sapphi-red]

The latest version is 5.0.0 and that PR is included in 5.0.0 or 5.0.0-beta.3.

[baurine]

The latest version is 5.0.0 and that PR is included in 5.0.0 or 5.0.0-beta.3.

ok, thanks! let me try it later.

[baurine]

hi @sapphi-red , sorry I didn't find the responding version in the https://www.npmjs.com/package/@openapitools/openapi-generator-cli , did version 5.0.0 and 5.0.0-beta.3 release to npm, or I should install 2.1.16?

My current version is "^1.0.15-4.3.1". After running yarn upgrade @openapitools/openapi-generator-cli, it is upgraded to "1.0.15-5.0.0-beta"

"@openapitools/openapi-generator-cli@^1.0.15-4.3.1":
- version "1.0.15-4.3.1"- resolved "https://registry.yarnpkg.com/@openapitools/openapi-generator-cli/-/openapi-generator-cli-1.0.15-4.3.1.tgz#25ef943eba3c82e82379b30f858bb05ed97dae0b"- integrity sha512-U+sanspDmeBElVNjYHQ4U7BbSEJUQzjNKmiTzXpcEw/r93sgxmzS2Sew5t+Zj6kyN1YTvjhRjJikNcW9/bmTKA==+ version "1.0.15-5.0.0-beta"+ resolved "https://registry.yarnpkg.com/@openapitools/openapi-generator-cli/-/openapi-generator-cli-1.0.15-5.0.0-beta.tgz#01b4805308d10762655158f446ebc54032ca33cc"+ integrity sha512-4Sbl/o2XbArryKnvsAtrK4UwXe0nTGnHErkYlMuIZYWBIZdEq8EeHHHHcVLlH1K3LZVP+uu18If51DcLtqVW4A==

[sapphi-red]

@baurine You need to install 2.x.x for using 5.0.0-beta.2 and later. yarn upgrade won't bump versions which does not match with pattern written in package.json, so you need to run yarn upgrade --latest @openapitools/openapi-generator-cli. After installing it, set the version in config (https://www.npmjs.com/package/@openapitools/openapi-generator-cli#configuration).

[baurine]

hi @sapphi-red , it works after upgrading to 2.1.16, thank you!

I just a little didn't understand, the old version just depends on ONE npm package while the new version depends on a ton of npm packages (likes nestjs, nuxtjs ...), isn't it just a wrapper of the jar? why does it need other npm packages?

[sapphi-red]

I do not know about that, maybe creating an issue at the repository below would be better.
https://github.com/OpenAPITools/openapi-generator-cli