Skip to content

[php-slim4] Move config to a separate file - #6971

Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom
ybelenko:6854_slim4_config
Aug 28, 2020
Merged

[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom
ybelenko:6854_slim4_config

Conversation

@ybelenko

@ybelenkoybelenko commented Jul 17, 2020

Copy link
Copy Markdown
Contributor

I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.

I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:

return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];

Closes#6854

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon

@ybelenkoybelenko added this to the 5.0.0 milestone Jul 17, 2020
@OpenAPIToolsOpenAPITools deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko

ybelenko commented Jul 25, 2020

Copy link
Copy Markdown
ContributorAuthor

cc Slim4 team member @l0gicgate

@ybelenkoybelenko mentioned this pull request Aug 6, 2020
Closed
6 tasks
@ybelenko

ybelenko commented Aug 6, 2020

Copy link
Copy Markdown
ContributorAuthor

Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.

@ybelenko

ybelenko commented Aug 27, 2020

Copy link
Copy Markdown
ContributorAuthor

I guess silence means that all reviewers agree to this changes 😄

@wing328 could you merge it when you have time? I have two coming up PRs waiting.

@wing328
wing328 merged commit da9f2f7 into OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko deleted the 6854_slim4_config branch August 28, 2020 16:52
jimschubert added a commit to jirikuncar/openapi-generator that referenced this pull request Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit to Patouche/openapi-generator that referenced this pull request Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit that referenced this pull request Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit to zippolyte/openapi-generator that referenced this pull request Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement: FeatureServer: PHP

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file

2 participants

@ybelenko@wing328
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[php-slim4] Move config to a separate file by ybelenko · Pull Request #6971 · OpenAPITools/openapi-generator · GitHub
Skip to content
[php-slim4] Move config to a separate file - #6971
Merged
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Aug 28, 2020
Merged
[php-slim4] Move config to a separate file#6971
wing328 merged 6 commits into
OpenAPITools:masterfrom 
ybelenko:6854_slim4_config
Conversation
@ybelenko
@ybelenkoybelenko
commented
Jul 17, 2020

Copy link


Copy Markdown

Contributor
I've used current Slim4 server in my personal project and I think that config file should be extracted from index.php. The most suitable format is config.inc.php.
I've added config folder with example.inc.php. User should copy that file to config/dev/config.inc.php and config/prod/config.inc.php. I prefer config.inc.php format over .env and .ini because these formats can be used only for flags or string variables. So config.inc.php file is the only way if you need to specify callback:
return [
'getPDOConnection' => function () {
returnnewPDO('mysql:dbname=dbname;host=localhost;charset=UTF8', 'root', 'root');
},
];
Closes#6854
PR checklist
  •  Read the contribution guidelines.
  •  If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  •  Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  •  File the PR against the correct branch: master
  •  Copy the technical committee to review the pull request if your PR is targeting a particular programming language.
cc @jebentier@dkarlovi@mandrean@jfastnacht@ackintosh@renepardon
@ybelenkoybelenko
added this to the 5.0.0 milestone
Jul 17, 2020
@OpenAPIToolsOpenAPITools
deleted a comment from auto-labelerBotJul 17, 2020
@ybelenko

This comment has been minimized.

Sign in to view
@ybelenko
ybelenko
commented
Jul 25, 2020

Copy link


Copy Markdown

ContributorAuthor
cc Slim4 team member @l0gicgate
@ybelenkoybelenko
mentioned this pull request
Aug 6, 2020

Closed

6 tasks
@ybelenko
ybelenko
commented
Aug 6, 2020

Copy link


Copy Markdown

ContributorAuthor
Notice to reviewers! Don't mind force push please, I did git rebase master to fix merge conflict and keep clean git commit history. There are no changes in PR itself.
@ybelenko
ybelenko
commented
Aug 27, 2020

Copy link


Copy Markdown

ContributorAuthor
I guess silence means that all reviewers agree to this changes 😄
@wing328 could you merge it when you have time? I have two coming up PRs waiting.
@wing328
wing328
merged commit da9f2f7
into
OpenAPITools:masterAug 28, 2020
@ybelenko
ybelenko
deleted the

6854_slim4_config

branch
August 28, 2020 16:52
jimschubert added a commit
to jirikuncar/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into extensions/x-auth-id-alias
ff8790a
* master: (355 commits)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
add extension for hashable in swift5 (OpenAPITools#7300)
[kotlin][client] fix warning Extension is shadowed by a member (OpenAPITools#7286)
Add wbt-solutions logo (OpenAPITools#7298)
[c-sharp] Fix default values with discriminator (OpenAPITools#7296)
Add x-is-json to csharp generators (OpenAPITools#7293)
Add raksul (OpenAPITools#7295)
Add wbt-solutions as using company (OpenAPITools#7292)
[C][Client][Clang Static Analyzer] Fix memory leak in apiClient_invoke (OpenAPITools#7285)
[Java][clients] remove java.lang prefix from Object (OpenAPITools#6806)
[core] Add x-is-free-form vendor extension (OpenAPITools#6849)
...
jimschubert added a commit
to Patouche/openapi-generator
that referenced
this pull request
Aug 31, 2020
@jimschubert
Merge branch 'master' into feature/2901-integrate-property-to-remove-…
82a56e7
…json-nullable
* master:
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
Adds generator unaliasSchema method, uses it to refactor python-experimental (OpenAPITools#7274)
[Rust][reqwest] prefix local variables with "local_var" (OpenAPITools#7299)
[Java][jersey2]Support enum discriminator value in child objects (OpenAPITools#7267)
[C][Client][Clang Static Analyzer] Fix memory leak before function returnning (OpenAPITools#7302)
jimschubert added a commit
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into path-handling
164fd7d
* master: (89 commits)
add structPrefix support to go-experimental (#7327)
Add a link to SmartHR Tech Blog (#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (#7323)
Correct allOf with only one child schema (no discriminator) (#6901)
[Go]: Interface definitions for api functions (#5914)
Update bug_report.md (#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (#7306)
Remove dot in golang type (#7307)
[doc] Document usage of post-process file feature (#7315)
fix http bear auth documentation for go clinets (#7312)
[Extensions][Go][Java] Test x-auth-id-alias (#6642)
[php-slim4] Move config to a separate file (#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (#7309)
Fix typescript-node generation when only models are generated (#7127)
update spring config to use java8 (#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (#7305)
[Java] remove deprecated jackson classes (#7304)
...
jimschubert added a commit
to zippolyte/openapi-generator
that referenced
this pull request
Sep 2, 2020
@jimschubert
Merge branch 'master' into hippo/unalias
97700cd
* master: (984 commits)
add structPrefix support to go-experimental (OpenAPITools#7327)
Add a link to SmartHR Tech Blog (OpenAPITools#7324)
Revert "Correct allOf with only one child schema (no discriminator)" (OpenAPITools#7323)
Correct allOf with only one child schema (no discriminator) (OpenAPITools#6901)
[Go]: Interface definitions for api functions (OpenAPITools#5914)
Update bug_report.md (OpenAPITools#7320)
update samples
[Java][Client] Use java8 OffsetDateTime for clients (OpenAPITools#7190)
[java] Intro openApiNullable property to enable/disable OpenAPI Jackson Nullable library (OpenAPITools#6154)
[Spring Boot] update dependencies, mark java8 option as deprecated (OpenAPITools#7306)
Remove dot in golang type (OpenAPITools#7307)
[doc] Document usage of post-process file feature (OpenAPITools#7315)
fix http bear auth documentation for go clinets (OpenAPITools#7312)
[Extensions][Go][Java] Test x-auth-id-alias (OpenAPITools#6642)
[php-slim4] Move config to a separate file (OpenAPITools#6971)
[C][Client][Clang Static Analyzer] Remove the useless free operation for (OpenAPITools#7309)
Fix typescript-node generation when only models are generated (OpenAPITools#7127)
update spring config to use java8 (OpenAPITools#7308)
[C][Client][Clang Static Analyzer] Fix uninitialized argument value (OpenAPITools#7305)
[Java] remove deprecated jackson classes (OpenAPITools#7304)
...
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers


No reviews


Assignees


No one assigned


Labels

Enhancement: FeatureServer: PHP

Projects


None yet


Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

[REQ][php-slim4] Move config to a separate file


2 participants

@ybelenko@wing328