[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) by Orachigami · Pull Request #9192 · OpenAPITools/openapi-generator

Orachigami · 2021-04-06T14:26:04Z

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Orachigami · 2021-04-06T14:26:04Z

Fixes: #8255

Replaced @InputFile and @PathSensitive annotations with @Optional and @Input annotations for the inputSpec parameter
Added test that checks project generation with a remote spec

Related PR #6716 change: here

PR checklist

Read the contribution guidelines.
Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in a delayed response from the community.
Run the following to build the project and update samples:
```
./mvnw clean package ./bin/generate-samples.sh
./bin/utils/export_docs_generators.sh
```
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example, ./bin/generate-samples.sh bin/configs/java*.
For Windows users, please run the script in Git BASH.
File the PR against the correct branch: master, 5.1.x, 6.0.x
If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

…ter became annotated with `@InputFile`. However, the `@InputFile` annotation is not suitable for `String` to `File` conversion in the case of the `URL` specification location. `CodegenConfigurator.toContext()` method eagerly converts the `inputSpec` parameter to the `OpenAPI` instance via `OpenAPIParser.readLocation`. Added a remote specification project generation test and a WireMock dependency

…" for build success

joschi · 2021-04-26T13:11:21Z

- @get:InputFile
- @PathSensitive(PathSensitivity.RELATIVE)
+ @Optional
+ @Input


This would unfortunately mean that even if the input specification in a local file changed, the task would be up-to-date because it's only checking the filename but not its contents.
Maybe splitting the input specification location into local specs and remote specs would make sense?

@joschi, if I extend this PR with the solution to check the modification status of the remote source will it do the trick? I mean let's imagine that the Up-to-date check works with the Url/Path then will you agree to use specificationUrl?

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Alexander added 3 commits April 5, 2021 15:02

ASF-13569 Removed redundant test, removed wiremock dependency
4d133f5

ASF-13569 Updated annotations
d570a47

Orachigami requested a review from jimschubert as a code owner April 6, 2021 14:26

Revert "ASF-13569 Removed redundant test, removed wiremock dependency…
e944297
…" for build success

Orachigami changed the title ~~[Kotlin] Issue #8255 fix (inputSpec param not accepts URL)~~[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL)Apr 7, 2021

joschi reviewed Apr 26, 2021
View reviewed changes

Orachigami mentioned this pull request Sep 1, 2021
[Kotlin][gradle] Issue #8255 fix (inputSpec param not accepts URL) #10307
Closed
5 tasks

Uh oh!

Uh oh!

Conversation

Orachigami commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Orachigami commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Orachigami commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Orachigami commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Uh oh!

Conversation

Orachigami commented Apr 6, 2021• edited Loading Uh oh! There was an error while loading. Please reload this page.

Orachigami commented Apr 6, 2021•
edited
Loading

Orachigami commented Apr 6, 2021•
edited
Loading

Orachigami commented Apr 6, 2021•
edited
Loading

Orachigami commented Apr 6, 2021•
edited
Loading

Orachigami commented Apr 6, 2021•
edited
Loading

Orachigami commented Apr 6, 2021•
edited
Loading