Skip to content

Fix string concat in SQL query - #594

Closed
JakeHuneau-LSPedia wants to merge 1 commit into
OpenAS2:masterfrom
JakeHuneau-LSPedia:fix-mdn-sql-quoting
Closed

Fix string concat in SQL query#594
JakeHuneau-LSPedia wants to merge 1 commit into
OpenAS2:masterfrom
JakeHuneau-LSPedia:fix-mdn-sql-quoting

Conversation

@JakeHuneau-LSPedia

Copy link
Copy Markdown
Contributor

There was an issue with the string concatenation for MDN where it would have an apostrophe like it's and this would cause a SQL error.

@uhurusurfa

Copy link
Copy Markdown
Contributor

CI/CD failure:

INSERT INTO msg_metadata (MSG_ID,RESEND_COUNT,STATE,MDN_RESPONSE,CREATE_DT) VALUES (?,?,?,?,?) [23502-240] ::: Data map: {state=msg_sent_mdn_received_ok, msg_id=, resend_count=0, mdn_response=The message sent to Recipient OpenAs2_Prod has been received, the EDI Interchange was successfully decrypted and it's integrity was verified.
}
org.h2.jdbc.JdbcSQLIntegrityConstraintViolationException: NULL not allowed for column "SENDER_ID"; SQL statement:
INSERT INTO msg_metadata (MSG_ID,RESEND_COUNT,STATE,MDN_RESPONSE,CREATE_DT) VALUES (?,?,?,?,?) [23502-240]
at org.h2.message.DbException.getJdbcSQLException(DbException.java:520)
at org.h2.message.DbException.getJdbcSQLException(DbException.java:489)
at org.h2.message.DbException.get(DbException.java:223)
at org.h2.message.DbException.get(DbException.java:199)
at org.h2.table.Column.validateConvertUpdateSequence(Column.java:406)
at org.h2.table.Table.convertInsertRow(Table.java:948)
at org.h2.command.dml.Insert.insertRows(Insert.java:167)
at org.h2.command.dml.Insert.update(Insert.java:135)
at org.h2.command.dml.DataChangeStatement.update(DataChangeStatement.java:77)
at org.h2.command.CommandContainer.update(CommandContainer.java:139)
at org.h2.command.Command.executeUpdate(Command.java:306)
at org.h2.command.Command.executeUpdate(Command.java:250)
at org.h2.jdbc.JdbcPreparedStatement.executeUpdateInternal(JdbcPreparedStatement.java:213)
at org.h2.jdbc.JdbcPreparedStatement.executeUpdate(JdbcPreparedStatement.java:172)
at org.openas2.processor.msgtracking.DbTrackingModule.persist(DbTrackingModule.java:181)
at org.openas2.processor.msgtracking.DbTrackingModulePersistInjectionTest.mdnTextWithApostropheRoundTrips(DbTrackingModulePersistInjectionTest.java:121)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@JakeHuneau-LSPedia@uhurusurfa