Skip to content

Logging - #490

Merged
rettigl merged 11 commits into
v1_feature_branchfrom
logging
Sep 19, 2024
Merged

Logging#490
rettigl merged 11 commits into
v1_feature_branchfrom
logging

Conversation

@rettigl

Copy link
Copy Markdown
Member

This PR converts all output into logger entries.
It also adds a call logger to record all function calls on the main workflow functions in the processor class

@coveralls

coveralls commented Aug 13, 2024

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 10948948523

Details

  • 283 of 341(82.99%) changed or added relevant lines in 12 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 92.522%

Changes Missing CoverageCovered LinesChanged/Added Lines%
sed/core/logging.py363797.3%
sed/loader/base/loader.py5771.43%
sed/calibrator/delay.py252889.29%
sed/loader/flash/loader.py101376.92%
sed/loader/sxp/loader.py101376.92%
sed/calibrator/momentum.py364090.0%
sed/calibrator/energy.py364481.82%
sed/core/processor.py8710483.65%
sed/loader/mpes/loader.py234057.5%
Files with Coverage ReductionNew Missed Lines%
sed/calibrator/energy.py192.6%
TotalsCoverage Status
Change from base Build 10948927564:-0.2%
Covered Lines:7238
Relevant Lines:7823

💛 - Coveralls

This was referenced Aug 14, 2024
@rettigl
rettiglforce-pushed the logging branch 2 times, most recently from b3328cd to 82ce3f2CompareAugust 14, 2024 07:44
Comment threadsed/calibrator/delay.py
Comment threadsed/core/logging.py Outdated
Comment threadsed/core/logging.py
Comment threadsed/core/logging.py
Comment threadsed/calibrator/delay.py Outdated
Comment threadsed/calibrator/delay.py

@zain-sohailzain-sohail left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge. Perhaps the comments I mentioned can be looked at, or can be done at another time.

@rettigl
rettigl merged commit c90e839 into v1_feature_branchSep 19, 2024
@rettigl
rettigl deleted the logging branch September 19, 2024 21:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rettigl@coveralls@zain-sohail