Skip to content

Pydantic error handling - #549

Merged
rettigl merged 3 commits into
v1_feature_branchfrom
pydantic-error-handling
Jan 16, 2025
Merged

Pydantic error handling#549
rettigl merged 3 commits into
v1_feature_branchfrom
pydantic-error-handling

Conversation

@zain-sohail

@zain-sohailzain-sohail commented Jan 13, 2025

Copy link
Copy Markdown
Member

closes#544

@zain-sohail
zain-sohail changed the base branch from main to v1_feature_branchJanuary 13, 2025 00:05
rettigl
rettigl reviewed Jan 13, 2025
View reviewed changes

@rettiglrettigl left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe just adding a logger mesage is sufficient, rather than creating a new error type.
You can also use a ValueError with from e

Comment threadsrc/sed/core/config.py Outdated
Comment threadtests/test_config.py
@coveralls

coveralls commented Jan 14, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 12798915516

Details

  • 4 of 4(100.0%) changed or added relevant lines in 1 file are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 92.131%
Files with Coverage ReductionNew Missed Lines%
src/sed/binning/numba_bin.py387.62%
TotalsCoverage Status
Change from base Build 12798864009:-0.04%
Covered Lines:7692
Relevant Lines:8349
💛 - Coveralls

@rettigl
rettigl merged commit 1752d34 into v1_feature_branchJan 16, 2025
@rettigl
rettigl deleted the pydantic-error-handling branch January 16, 2025 14:41
@zain-sohailzain-sohail mentioned this pull request Jan 16, 2025
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rettiglrettiglrettigl approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Throw a better error pydantic

3 participants

@zain-sohail@coveralls@rettigl