Skip to content

Mpes elab metadata - #551

Merged
rettigl merged 6 commits into
update_pynxtoolsfrom
mpes_elab_metadata
Apr 4, 2025
Merged

Mpes elab metadata#551
rettigl merged 6 commits into
update_pynxtoolsfrom
mpes_elab_metadata

Conversation

@rettigl

Copy link
Copy Markdown
Member

This PR adds metadata retrieval from elabFTW at fhi.

Base automatically changed from flash-metadata-fixes to v1_feature_branchJanuary 15, 2025 23:28
@rettigl
rettiglforce-pushed the mpes_elab_metadata branch 2 times, most recently from e08911f to 8d969e0CompareJanuary 16, 2025 14:39
@coveralls

coveralls commented Jan 16, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Test Coverage Report for Build 13641008901

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 280 of 309(90.61%) changed or added relevant lines in 5 files are covered.
  • 10 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.3%) to 92.444%

Changes Missing CoverageCovered LinesChanged/Added Lines%
src/sed/loader/mpes/loader.py6785.71%
src/sed/loader/mpes/metadata.py15918785.03%
Files with Coverage ReductionNew Missed Lines%
src/sed/core/processor.py1085.64%
TotalsCoverage Status
Change from base Build 13167417292:0.3%
Covered Lines:8161
Relevant Lines:8828

💛 - Coveralls

@zain-sohail
zain-sohail self-requested a review January 16, 2025 15:14
@zain-sohail

Copy link
Copy Markdown
Member

Hard for me to test this without any access. But I notice tests missing. Rather up to you if you'd like to include them or have done rough integration tests already.

@rettigl

Copy link
Copy Markdown
MemberAuthor

Hard for me to test this without any access. But I notice tests missing. Rather up to you if you'd like to include them or have done rough integration tests already.

This is a draft so far. I will include tests eventually

@rettiglrettigl mentioned this pull request Feb 4, 2025
12 tasks
@rettigl
rettigl changed the base branch from v1_feature_branch to mainFebruary 5, 2025 21:58
@rettiglrettigl mentioned this pull request Mar 25, 2025
@rettigl

Copy link
Copy Markdown
MemberAuthor

@zain-sohail can you give this a quick review so we can merge it?

@rettigl
rettigl changed the base branch from main to update_pynxtoolsApril 4, 2025 22:04
@rettigl
rettigl merged commit 55da2c1 into update_pynxtoolsApr 4, 2025
@rettigl
rettigl deleted the mpes_elab_metadata branch April 4, 2025 22:05
@rettigl
rettigl restored the mpes_elab_metadata branch April 4, 2025 22:09
@rettigl
rettigl deleted the mpes_elab_metadata branch April 4, 2025 22:16
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@rettigl@coveralls@zain-sohail