Skip to content

chore(cache): improve invalidation logic - #45

Draft
sidux wants to merge 7 commits into
masterfrom
improve-cache-invalidation
Draft

chore(cache): improve invalidation logic#45
sidux wants to merge 7 commits into
masterfrom
improve-cache-invalidation

Conversation

@sidux

@siduxsidux commented Jul 8, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor
  • add more tests
  • since tags now have the name of the property or the method added we need to check how to invalidate them all (drop redis database ?)
  • check possible edge cases with imbricated requests
  • add test to check key invalidation when manual tags change

@sidux
sidux requested review from Shivoham and kletordJuly 8, 2024 10:33
@sidux
siduxforce-pushed the improve-cache-invalidation branch 2 times, most recently from 1df0ed1 to 3dfa67fCompareJuly 8, 2024 12:27
@sidux
siduxforce-pushed the improve-cache-invalidation branch from 3dfa67f to 4d8df97CompareJuly 8, 2024 12:56
@sidux
siduxforce-pushed the improve-cache-invalidation branch 3 times, most recently from 1f0a28c to b8729a3CompareJuly 8, 2024 14:55
@github-actions

github-actionsBot commented Jul 8, 2024

Copy link
Copy Markdown

Issued by Coverage Checker:

sidux
sidux commented Jul 8, 2024
View reviewed changes
Comment threadsrc/Interceptor/Impl/CacheTagsTrait.php Outdated

@siduxsiduxJul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests

sidux
sidux commented Jul 8, 2024
View reviewed changes
Comment threadsrc/Interceptor/Impl/CacheTagsTrait.php Outdated

@siduxsiduxJul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test

sidux
sidux commented Jul 8, 2024
View reviewed changes
Comment threadsrc/Interceptor/Impl/CacheTagsTrait.php Outdated

@siduxsiduxJul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs test

sidux
sidux commented Jul 8, 2024
View reviewed changes
Comment threadsrc/Interceptor/Impl/CacheTagsTrait.php Outdated

@siduxsiduxJul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs tests

sidux
sidux commented Jul 8, 2024
View reviewed changes
Comment threadsrc/Interceptor/Impl/CacheTagsTrait.php Outdated

@siduxsiduxJul 8, 2024

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a possible embedded requests edge case ?

@sidux
siduxforce-pushed the improve-cache-invalidation branch from b8729a3 to 2d77187CompareJuly 8, 2024 15:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kletordkletordAwaiting requested review from kletord
@ShivohamShivohamAwaiting requested review from Shivoham

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sidux