Skip to content

Fix deprecation warning for usort#23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kletord merged 1 commit into from
Mar 4, 2026
Merged

Fix deprecation warning for usort #23

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions src/OpenClassrooms/UseCase/Application/Services/Proxy/UseCases/UseCaseProxy.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -179,8 +179,13 @@ private function sortPreStrategies()
usort(
$this->strategies,
function (ProxyStrategyBag $s1, ProxyStrategyBag $s2) {
return array_search($s1->getType(), UseCaseProxy::$strategyPreOrder) >
array_search($s2->getType(), UseCaseProxy::$strategyPreOrder);
$pos1 = array_search($s1->getType(), UseCaseProxy::$strategyPreOrder);
$pos2 = array_search($s2->getType(), UseCaseProxy::$strategyPreOrder);

$pos1 = (false === $pos1) ? PHP_INT_MAX : $pos1;
$pos2 = (false === $pos2) ? PHP_INT_MAX : $pos2;

return $pos1 <=> $pos2;
}
);
}
Expand DownExpand Up@@ -215,8 +220,13 @@ private function sortPostStrategies()
usort(
$this->strategies,
function (ProxyStrategyBag $s1, ProxyStrategyBag $s2) {
return array_search($s1->getType(), UseCaseProxy::$strategyPostOrder) >
array_search($s2->getType(), UseCaseProxy::$strategyPostOrder);
$pos1 = array_search($s1->getType(), UseCaseProxy::$strategyPostOrder);
$pos2 = array_search($s2->getType(), UseCaseProxy::$strategyPostOrder);

$pos1 = (false === $pos1) ? PHP_INT_MAX : $pos1;
$pos2 = (false === $pos2) ? PHP_INT_MAX : $pos2;

return $pos1 <=> $pos2;
}
);
}
Expand All@@ -242,8 +252,13 @@ private function sortOnExceptionStrategies()
usort(
$this->strategies,
function (ProxyStrategyBag $s1, ProxyStrategyBag $s2) {
return array_search($s1->getType(), UseCaseProxy::$strategyOnExceptionOrder) >
array_search($s2->getType(), UseCaseProxy::$strategyOnExceptionOrder);
$pos1 = array_search($s1->getType(), UseCaseProxy::$strategyOnExceptionOrder);
$pos2 = array_search($s2->getType(), UseCaseProxy::$strategyOnExceptionOrder);

$pos1 = (false === $pos1) ? PHP_INT_MAX : $pos1;
$pos2 = (false === $pos2) ? PHP_INT_MAX : $pos2;

return $pos1 <=> $pos2;
}
);
}
Expand Down
Loading