Skip to content

OpenConceptLab/ocl_issues#2560 | removed hardcoded fallbacks for CIEL bridge URL - #46

Merged
snyaggarwal merged 3 commits into
mainfrom
issues#2560
Jun 11, 2026
Merged

OpenConceptLab/ocl_issues#2560 | removed hardcoded fallbacks for CIEL bridge URL#46
snyaggarwal merged 3 commits into
mainfrom
issues#2560

Conversation

@snyaggarwal

@snyaggarwalsnyaggarwal commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

@snyaggarwal
snyaggarwal requested a review from paynejdJune 11, 2026 04:38
@snyaggarwalsnyaggarwal self-assigned this Jun 11, 2026

@paynejdpaynejd left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving — clean, surgical removal of the CIEL/latest fallbacks. The oclmap↔react-bridge-match mappedRepoURLs wiring is consistent (gated on non-empty mappedSrcs), and all 174 unit tests pass on the branch.

One non-blocking note inline on the API preload effect (finding #1). Two minor follow-ups for later: the migration SQL scripts named in #2560 (item 6) are intentionally left untouched — worth a one-line note on the issue so the remaining scope is tracked; and the sibling react-bridge-match PR still keeps a bridgeRepoVersion || 'latest' fallback (unreachable in this flow, but contradicts the cleanup intent).

Comment threadsrc/components/map-projects/MapProject.jsx Outdated
@snyaggarwal
snyaggarwal merged commit 1899caf into mainJun 11, 2026
1 check passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cleanup CIEL Bridge flow hardcoded fallbacks

2 participants

@snyaggarwal@paynejd