Uh oh!
There was an error while loading. Please reload this page.
OpenConceptLab/ocl_issues#2560 | removed hardcoded fallbacks for CIEL bridge URL - #46
Conversation
paynejd
left a comment
There was a problem hiding this comment.
Approving — clean, surgical removal of the CIEL/latest fallbacks. The oclmap↔react-bridge-match mappedRepoURLs wiring is consistent (gated on non-empty mappedSrcs), and all 174 unit tests pass on the branch.
One non-blocking note inline on the API preload effect (finding #1). Two minor follow-ups for later: the migration SQL scripts named in #2560 (item 6) are intentionally left untouched — worth a one-line note on the issue so the remaining scope is tracked; and the sibling react-bridge-match PR still keeps a bridgeRepoVersion || 'latest' fallback (unreachable in this flow, but contradicts the cleanup intent).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Linked Issue
Refs OpenConceptLab/ocl_issues#2560
Sibling: https://github.com/OpenConceptLab/react-bridge-match/pull/4