Skip to content

Add Curso private controller and Curso refactor - #69

Open
paulofelipefeitosa wants to merge 2 commits into
masterfrom
curso-private-controller
Open

Add Curso private controller and Curso refactor#69
paulofelipefeitosa wants to merge 2 commits into
masterfrom
curso-private-controller

Conversation

@paulofelipefeitosa

Copy link
Copy Markdown
Member

No description provided.

@codecov

codecovBot commented Mar 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #69 into private-controllers will decrease coverage by 0.3%.
The diff coverage is 37.93%.

Impacted file tree graph

@@ Coverage Diff @@## private-controllers #69 +/- ##
=========================================================
- Coverage 80.42% 80.11% -0.31% - Complexity 281 284 +3 
=========================================================
Files 36 38 +2 Lines 664 674 +10 Branches 80 80 =========================================================
+ Hits 534 540 +6 - Misses 86 89 +3 - Partials 44 45 +1
Impacted FilesCoverage ΔComplexity Δ
...openenade/api/modalidade/ModalidadeController.java50% <ø> (ø)1 <0> (ø)⬇️
...e/api/categoriaadmin/CategoriaAdminController.java50% <ø> (ø)1 <0> (ø)⬇️
...rc/main/java/br/com/openenade/api/curso/Curso.java81.08% <ø> (ø)15 <0> (ø)⬇️
...penenade/api/universidade/UniversidadeService.java90.32% <0%> (+7.96%)14 <0> (ø)⬇️
...om/openenade/api/modalidade/ModalidadeService.java0% <0%> (ø)0 <0> (?)
...m/openenade/api/categoriaadmin/CategoriaAdmin.java75% <100%> (ø)3 <0> (ø)⬇️
...va/br/com/openenade/api/modalidade/Modalidade.java80% <100%> (+2.22%)3 <2> (ø)⬇️
...om/openenade/api/curso/PrivateCursoController.java20% <20%> (ø)1 <1> (?)
...com/openenade/api/curso/PublicCursoController.java33.33% <33.33%> (ø)1 <1> (?)
.../java/br/com/openenade/api/curso/CursoService.java75% <57.14%> (-25%)5 <1> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9f337...38624e6. Read the comment docs.

@codecov

codecovBot commented Mar 3, 2019

Copy link
Copy Markdown

Codecov Report

Merging #69 into master will decrease coverage by 0.3%.
The diff coverage is 37.93%.

Impacted file tree graph

@@ Coverage Diff @@## master #69 +/- ##
============================================
- Coverage 80.42% 80.11% -0.31% - Complexity 281 284 +3 
============================================
Files 36 38 +2 Lines 664 674 +10 Branches 80 80 ============================================
+ Hits 534 540 +6 - Misses 86 89 +3 - Partials 44 45 +1
Impacted FilesCoverage ΔComplexity Δ
...openenade/api/modalidade/ModalidadeController.java50% <ø> (ø)1 <0> (ø)⬇️
...e/api/categoriaadmin/CategoriaAdminController.java50% <ø> (ø)1 <0> (ø)⬇️
...rc/main/java/br/com/openenade/api/curso/Curso.java81.08% <ø> (ø)15 <0> (ø)⬇️
...penenade/api/universidade/UniversidadeService.java90.32% <0%> (+7.96%)14 <0> (ø)⬇️
...om/openenade/api/modalidade/ModalidadeService.java0% <0%> (ø)0 <0> (?)
...m/openenade/api/categoriaadmin/CategoriaAdmin.java75% <100%> (ø)3 <0> (ø)⬇️
...va/br/com/openenade/api/modalidade/Modalidade.java80% <100%> (+2.22%)3 <2> (ø)⬇️
...om/openenade/api/curso/PrivateCursoController.java20% <20%> (ø)1 <1> (?)
...com/openenade/api/curso/PublicCursoController.java33.33% <33.33%> (ø)1 <1> (?)
.../java/br/com/openenade/api/curso/CursoService.java75% <57.14%> (-25%)5 <1> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be9f337...477d863. Read the comment docs.

@paulofelipefeitosa

Copy link
Copy Markdown
MemberAuthor

This pull request introduces 1 alert when merging 38624e6 into be9f337 - view on LGTM.com

new alerts:

  • 1 for Array index out of bounds

Comment posted by LGTM.com

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@paulofelipefeitosa@joivo