Skip to content
This repository was archived by the owner on Nov 27, 2023. It is now read-only.

Added a example related to Turbsim file processing - #24

Merged
ebranlard merged 10 commits into
OpenFAST:mainfrom
tatesnow:main
Dec 17, 2021
Merged

Added a example related to Turbsim file processing#24
ebranlard merged 10 commits into
OpenFAST:mainfrom
tatesnow:main

Conversation

@tatesnow

@tatesnowtatesnow commented Dec 15, 2021

Copy link
Copy Markdown
Contributor

Includes turbsim input file modification, running and post-processing

@tatesnow
Added a example related to Turbsim file processing
4e584c3
Includes turbsim input file modification, running and post-processing
@ebranlard

ebranlard commented Dec 15, 2021

Copy link
Copy Markdown
Collaborator

Hi @tatesnow,
Thanks for doing that. Can you --force push a new commit with the following changes:

  • do not include the executable in the commit.
  • use python files instead of ipython notebooks.
  • put the example script into pyFAST\input_output\examples directly
  • put the example turbsim at the following location pyFAST\input_output\tests\example_files\FASTIn_TurbSim.dat
    I might have some other comments after that. But that's a good start!

@tatesnow

tatesnow commented Dec 16, 2021

Copy link
Copy Markdown
ContributorAuthor

Hi @ebranlard,
Thanks for your suggestions, I will revise it and resubmit it by today.
In addition, I am currently learning about the toolbox you developed, which really helped me a lot!

@tatesnow
Added TurbSim example
4fa17a0
Added TurbSim parameter modification, run, and result saving functions
@tatesnow
Added TurbSim input file
f7c9990
Input file corresponding to the TurbSim example
@tatesnow
Modify the path to the executable file
b381006
Modify the path to the executable file
@tatesnow
Delete pyFAST/input_output/examples/Example_TurbSim directory
9eb08ef
@tatesnow

tatesnow commented Dec 16, 2021

Copy link
Copy Markdown
ContributorAuthor

Hi @ebranlard,
Based on your detailed comments and suggestions, I have modified the code.

@ebranlard
ebranlard self-requested a review December 16, 2021 06:10
ebranlard
ebranlard suggested changes Dec 16, 2021
View reviewed changes

@ebranlardebranlard left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks a lot. I've added a couple of comments.

Also, can you please add a small description of your example here: pyFAST/input_output/examples/README.md

Thanks!

Comment threadpyFAST/input_output/examples/Example_TurbSim_Processing.py Outdated
Comment threadpyFAST/input_output/examples/Example_TurbSim_Processing.py Outdated
Comment threadpyFAST/input_output/tests/example_files/FASTIn_TurbSim.inp Outdated
ebranlard
ebranlard reviewed Dec 16, 2021
View reviewed changes
Comment threadpyFAST/input_output/tests/example_files/FASTIn_TurbSim.inp Outdated
@tatesnow
Modify the extension of the turbSim input file;
d568a16
Replace the path here with a generic path
@ebranlardebranlard added the documentation Improvements or additions to documentation label Dec 17, 2021
@ebranlard
ebranlard merged commit ee58dab into OpenFAST:mainDec 17, 2021
ebranlard added a commit that referenced this pull request Jan 4, 2022
MA Yuanchi@tatesnow
@ebranlardyuanchima
Modify spelling error and Update name of input file for example case (#…
bc36d22
…27)
* Added a example related to Turbsim file processing (#24)
* Added a example related to Turbsim file processing
* modify spelling errors in case_gen.py and runner.py
* Modify the Variable 'main_file' from Example folder files to match the correct file name
Co-authored-by: TAO Tao <42032942+tatesnow@users.noreply.github.com>
Co-authored-by: E. Branlard <1318316+ebranlard@users.noreply.github.com>
Co-authored-by: yuanchima <yuanchima@yeah.net>
Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer
@ebranlardebranlardebranlard requested changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

documentationImprovements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tatesnow@ebranlard