Skip to content

First attempt at ODE integration - #21

Merged
jhalpern30 merged 439 commits into
mainfrom
ode_team
Oct 9, 2025
Merged

First attempt at ODE integration#21
jhalpern30 merged 439 commits into
mainfrom
ode_team

Conversation

@jhalpern30

@jhalpern30jhalpern30 commented Jul 30, 2025

Copy link
Copy Markdown
Collaborator

First updates from the ODE team to add EL equation integration - still very much a work in progress. We are beginning to debug, so requesting help from equil team adding the equilibrium input to the main code

@jhalpern30jhalpern30 changed the title Ode teamFirst attempt at ODE integrationJul 30, 2025
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/dcon.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/dcon.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/dcon.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/Ode.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/fourfit.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/fourfit.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/fourfit.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/fourfit.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/fourfit.jl Outdated
jhalpern30
jhalpern30 commented Jul 30, 2025
View reviewed changes
Comment threadsrc/DCON/fourfit.jl Outdated
matt-pharr
matt-pharr reviewed Oct 9, 2025
View reviewed changes
Comment threadtest/runtests_ode.jl Outdated
matt-pharr
matt-pharr approved these changes Oct 9, 2025
View reviewed changes

@matt-pharrmatt-pharr left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! I would say we are ready to merge finally.

Comment threadsrc/Equilibrium/direct.txt Outdated
@matt-pharr

matt-pharr commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

@logan-nc Jake and I are both in agreement that this is ready to merge. Would you like to do the honors?

@bclyons12

bclyons12 commented Oct 9, 2025

Copy link
Copy Markdown
Collaborator

Excellent work all 👏

@jhalpern30
jhalpern30 merged commit f4aa1cc into mainOct 9, 2025
3 checks passed
@jhalpern30
jhalpern30 deleted the ode_team branch October 9, 2025 21:28
@orso82

orso82 commented Oct 9, 2025

Copy link
Copy Markdown

Fantastic news! 🎉 Congratulations for this achievement!

@dylan-p-brennan

dylan-p-brennan commented Oct 10, 2025

Copy link
Copy Markdown
Collaborator

Great job! Fantastic news! Looking forward to working with the code

This was referenced Oct 13, 2025
Closed
Closed
Closed
@logan-nclogan-nc added the refactor Behavior-preserving restructuring label Aug 17, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bclyons12bclyons12bclyons12 left review comments
@eburscheburschebursch left review comments
@logan-nclogan-nclogan-nc approved these changes
@matt-pharrmatt-pharrmatt-pharr approved these changes

Assignees

@logan-nclogan-nc

@AaronFroeseAaronFroese

@jhalpern30jhalpern30

@mfairborn23mfairborn23

@gwanggeunseogwanggeunseo

@dylan-p-brennandylan-p-brennan

Labels

refactorBehavior-preserving restructuring

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Refactor ideal DCON integrator

12 participants

@jhalpern30@matt-pharr@bclyons12@logan-nc@orso82@dylan-p-brennan@ebursch@AaronFroese@mfairborn23@gwanggeunseo@jmlmir369@jaesun57