Uh oh!
There was an error while loading. Please reload this page.
Flatten feign-bom so imports do not override consumer dependency management - #3508
Merged
velo merged 2 commits intoAug 11, 2026
Merged
Conversation
…gement Installing and deploying feign-bom previously published a POM that still parented feign-parent. Importing that BOM into a project such as Spring Boot also imported parent dependencyManagement (for example jackson-bom) and overrode the consumer's managed versions. Apply flatten-maven-plugin in bom mode on the BOM module and template so the published artifact only manages Feign modules. FixesOpenFeign#3505
…he committed feign-bom POM Signed-off-by: Marvin Froeder <velo.br@gmail.com>
velo
approved these changes
Aug 11, 2026
velo
left a comment
Member
There was a problem hiding this comment.
Verified the flattened BOM: no <parent>, only io.github.openfeign entries in dependencyManagement, and OSS metadata (licenses/scm/developers) correctly inlined for Central. A consumer importing the BOM drops from 192 managed artifacts (Jackson, JUnit, AssertJ, slf4j, Gson, OkHttp and friends leaking out of feign-parent) to 44 Feign modules with zero leakage.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Importing
feign-bominto a consumer that already manages versions (for example Spring Boot) previously pulledfeign-parentdependency management through the published BOM parent. That overrode consumer-managed artifacts such as Jackson.This applies
flatten-maven-plugininbommode on the committedfeign-bommodule and the sundr BOM template so the installed/deployed POM only manages Feign modules.Fixes#3505
Verification
./mvnw -N -Pquickbuild install./mvnw -pl feign-bom -Pquickbuild installfeign-bomPOM has no<parent>and no third-partydependencyManagemententriesspring-boot-starter-parent3.5.4:jackson-core2.19.2feign-bom13.13:jackson-core2.22.0 (override bug)feign-bom13.14-SNAPSHOT:jackson-core2.19.2 (Boot version kept)