Skip to content

Generate a builder - #11

Merged
tpiperatgod merged 1 commit into
OpenFunction:mainfrom
penghuima:dev
Aug 13, 2021
Merged

Generate a builder#11
tpiperatgod merged 1 commit into
OpenFunction:mainfrom
penghuima:dev

Conversation

@penghuima

@penghuimapenghuima commented Aug 13, 2021

Copy link
Copy Markdown
Member

After executing the command bazel build //builders/ruby26:builder.image, a builder image will be generated
the builder image penghuima/ruby26

@penghuimapenghuima linked an issue Aug 13, 2021 that may be closed by this pull request
Develop a builder #10
Closed
tpiperatgod
tpiperatgod requested changes Aug 13, 2021
View reviewed changes
Comment threadbuilders/ruby26/builder.toml Outdated
Comment threadbuilders/ruby26/BUILD.bazel Outdated
Comment threadbuilders/ruby26/BUILD.bazel Outdated
Comment threadbuilders/ruby26/BUILD.bazel Outdated
Comment threadbuilders/ruby26/BUILD.bazel Outdated
Comment threadbuilders/ruby26/BUILD.bazel Outdated
Comment threadbuilders/ruby26/builder.toml Outdated
Comment threadbuilders/ruby26/builder.toml Outdated
@tpiperatgod

tpiperatgod commented Aug 13, 2021

Copy link
Copy Markdown
Member

I think we might need entrypoint buildpack?

tpiperatgod
tpiperatgod requested changes Aug 13, 2021
View reviewed changes
Comment threadbuilders/ruby26/builder.toml Outdated
Comment on lines +12 to +13
id = "google.config.entrypoint"
uri = "entrypoint.tgz"

@tpiperatgodtpiperatgodAug 13, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to change the indent

@tpiperatgod
tpiperatgod merged commit 217b96f into OpenFunction:mainAug 13, 2021
@tpiperatgodtpiperatgod added the enhancement New feature or request label Aug 13, 2021
@penghuimapenghuima linked an issue Aug 14, 2021 that may be closed by this pull request
Modify configuration #12
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tpiperatgodtpiperatgodtpiperatgod approved these changes

Assignees

No one assigned

Labels

enhancementNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Modify configuration Develop a builder

2 participants

@penghuima@tpiperatgod