Skip to content

feat: enable HTTP function trigger async functions - #10

Merged
webup merged 7 commits into
masterfrom
feature/sync-trigger-async
May 18, 2022
Merged

feat: enable HTTP function trigger async functions#10
webup merged 7 commits into
masterfrom
feature/sync-trigger-async

Conversation

@webup

@webupwebup commented May 15, 2022

Copy link
Copy Markdown
Collaborator

Resolves#6

  • Enable Knative invoke async
  • Refine e2e and conformance tests
  • Update README and API docs

@auto-assign
auto-assignBot requested a review from benjaminhuoMay 15, 2022 08:41
webup added 4 commits May 15, 2022 16:59
@webup
👷 ci: add pre-push hook
ce63398
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup
✨ feat: enable HTTP trigger async function
797b912
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup
📝 doc: update README and API docs
add5844
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup
✏️ ci: fix mergeable bot config filename
63b7b79
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup
webupforce-pushed the feature/sync-trigger-async branch from f875712 to 63b7b79CompareMay 15, 2022 09:05
@webup

webup commented May 15, 2022

Copy link
Copy Markdown
CollaboratorAuthor

@benjaminhuo please help check whether the tryKnativeAsync sample in README is correct, thanks.

benjaminhuo
benjaminhuo reviewed May 16, 2022
View reviewed changes
Comment threadsrc/function_wrappers.ts Outdated
benjaminhuo
benjaminhuo reviewed May 16, 2022
View reviewed changes
Comment threadsrc/function_wrappers.ts Outdated
benjaminhuo
benjaminhuo reviewed May 16, 2022
View reviewed changes
Comment threadsrc/function_wrappers.ts
benjaminhuo
benjaminhuo reviewed May 16, 2022
View reviewed changes
Comment threadsrc/function_wrappers.ts
webup added 3 commits May 16, 2022 21:25
@webup
👔 refactor: add openfunction signature type
da606dd
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup
♻️ refactor(ofn/runtime): refine context proxy
74cbea9
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup
📝 doc: update REAMDE and CONTRUBUTINIG
8284d9f
Signed-off-by: Haili Zhang <haili.zhang@outlook.com>
@webup

webup commented May 17, 2022

Copy link
Copy Markdown
CollaboratorAuthor

@benjaminhuo please help review latest updates, many thanks.

@webup
webup merged commit 5eceefd into masterMay 18, 2022
@webup
webup deleted the feature/sync-trigger-async branch May 18, 2022 06:03
@webupwebup added the type: feature New feature or request label May 18, 2022
benjaminhuo
benjaminhuo reviewed May 18, 2022
View reviewed changes
Comment threadsrc/function_wrappers.ts
ctx.setTrigger(req, res);

Promise.resolve()
.then(() => userFunction(ctx, req.body))

@benjaminhuobenjaminhuoMay 18, 2022•
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for my late response, basically the new signature refactoring looks good.
One more thing, I think go ff's handling of function output and return error is more reasonable.
What if send fails? Here're more refs:

@webupwebup mentioned this pull request May 26, 2022
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjaminhuobenjaminhuobenjaminhuo left review comments

Assignees

@webupwebup

Labels

type: featureNew feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enable HTTP triggers for asynchronous functions

2 participants

@webup@benjaminhuo