Uh oh!
There was an error while loading. Please reload this page.
[#697] Fix global idle-time-limit having no effect on client connections - #684
Merged
vharseko merged 1 commit intoJul 8, 2026
Conversation
The global idle-time-limit was parsed by CoreConfigManager but only stored in its private CoreAttributes, which nothing reads. New client connections snapshot the limit from DirectoryServer.getIdleTimeLimit(), whose backing field was initialized to 0 and never updated since the setter had no callers, so neither the startup value nor dsconfig changes ever took effect; only the per-user ds-rlim-idle-time-limit worked. Push the value into DirectoryServer whenever the global configuration is applied (at startup and on change). Fix IdleTimeLimitTestCase to expect EOFException from RemoteConnection.readMessage() when the server closes the connection after the notice of disconnection, and move the suite out of the "slow" group into the default build now that it passes in ~30 seconds.
This was referenced Jul 4, 2026
maximthomas
approved these changes
Jul 5, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#697
Problem
The global
idle-time-limitsetting (cn=config) has no effect: neither the value from the configuration at startup nor changes made viadsconfig set-global-configuration-prop --set idle-time-limit:...are ever applied to client connections. Only the per-userds-rlim-idle-time-limitattribute works.Root cause:
CoreConfigManagerparses the setting into its privateCoreAttributes, which nothing reads back. New client connections snapshot the limit fromDirectoryServer.getIdleTimeLimit()(ClientConnectionconstructor, alsoLocalBackendBindOperation), but the backing field is initialized to0andDirectoryServer.setIdleTimeLimit()had no callers, so the value stayed0(disabled) forever.Found by running the
slowTestNG group, which is excluded from CI: both server-wideIdleTimeLimitTestCasetests were timing out after 60s because idle connections were never disconnected (IdleTimeLimitThreadruns, but every connection carriesidleTimeLimit=0).Fix
CoreConfigManager.applyGlobalConfigurationnow pushes the value intoDirectoryServer.setIdleTimeLimit()— this covers both server startup and dynamicdsconfigchanges.IdleTimeLimitTestCase: the helper now expectsEOFExceptionfromRemoteConnection.readMessage()when the server closes the connection after the notice of disconnection (RemoteConnectionthrows instead of returningnullsince its introduction), and the suite is moved out of theslowgroup into the default build now that it passes in ~30 seconds.Verification
IdleTimeLimitTestCase: 3/3 pass in ~34s under the default CI group filter (before: 3/3 failing, 190s). Access log confirmsDISCONNECT reason="Idle Time Limit Exceeded"with the notice of disconnection for both anonymous and authenticated connections.BindOperationTestCase(1142 tests) all pass.idle-time-limitis0(disabled), so behaviour is unchanged for deployments that do not set the option.