Uh oh!
There was an error while loading. Please reload this page.
Fix and enable broken tests from the slow group - #686
Merged
vharseko merged 1 commit intoJul 8, 2026
Conversation
These tests are excluded from CI (excludegroups=slow) and have rotted: - UpdateOperationTest.modifyConflicts asserted that Entry.getAllAttributes() returns null for an absent attribute, but it returns an empty list since the Entry API refactoring; the conflict resolution itself works. Assert an empty list instead. - UpdateOperationTest.namingConflicts read the resolved-naming-conflicts monitor counter right after publishing a DELETE with a wrong entryUUID. Unlike the other scenarios, the preceding getEntry() does not wait for the replay because the entry already exists, so the check raced with the replay thread. Poll the counter with TestTimer. - TopologyViewTest relied on fixed sleeps for topology propagation and compared the view exactly once; 1 second is not always enough for a newly started RS to appear in the DS view. Poll the topology view with TestTimer inside checkTopoView. - TestRebuildTask rebuilt the dn2uri index, which only existed in the legacy local DB backend; the JE backend rightfully rejects it. Drop dn2uri and keep dn2id. Move all four tests out of the "slow" group into the default build (~1.5 minutes for the three classes).
maximthomas
approved these changes
Jul 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The TestNG
slowgroup is excluded from CI (excludegroups=slowin the failsafe configuration), so these tests have rotted. A full audit of the group found four broken tests in three classes — all test-code defects, no product bugs involved.Fixes
UpdateOperationTest.modifyConflictsasserted thatEntry.getAllAttributes()returnsnullfor an absent attribute, but it returns an empty list since the Entry API refactoring, so the assert could never pass; the conflict resolution itself works. Assert an empty list instead.UpdateOperationTest.namingConflictsread theresolved-naming-conflictsmonitor counter right after publishing a DELETE with a wrong entryUUID. Unlike the other scenarios in this test, the precedinggetEntry()does not wait for the replay because the entry already exists, so the check raced with the replay thread. Poll the counter withTestTimer(same pattern already used elsewhere in the file).TopologyViewTestrelied on fixed sleeps for topology propagation and compared the view exactly once; one second is not always enough for a newly started RS to appear in the DS view (RS 52was missing from the actual view in STEP 3). Poll the topology view withTestTimerinsidecheckTopoView.TestRebuildTaskrebuilt thedn2uriindex, which only existed in the legacy local DB backend; the JE backend rightfully rejects it ("There is no index configured for attribute type 'dn2uri'"), so the task endedSTOPPED_BY_ERROR. Dropdn2uriand keepdn2id.All four tests are moved out of the
slowgroup into the default build (~1.5 minutes for the three classes).Verification
Under the default CI group filter:
UpdateOperationTest8/8 (40s),TopologyViewTest1/1 (33s),TestRebuildTask3/3 (18.5s). The two formerly race-prone classes were re-run twice more — all green.