Uh oh!
There was an error while loading. Please reload this page.
Add Dockerfile templating capability - #4
Open
kpalang wants to merge 4 commits into
Open
Conversation
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
kpalang
marked this pull request as ready for review
July 3, 2025 19:13
kpalang
requested review from
a team, gibson9583, jonbartels, kayyagari and tonygermano
and removed request for
a teamJuly 3, 2025 19:13
kpalangforce-pushed
the
feature/templated-dockerfiles
branch
from
July 3, 2025 20:34
889a82d to
4ed4d20Comparekpalang
marked this pull request as draft
July 3, 2025 20:38
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
kpalangforce-pushed
the
feature/templated-dockerfiles
branch
from
July 3, 2025 20:42
4ed4d20 to
ea559acComparekpalang
marked this pull request as ready for review
July 6, 2025 19:15
jonbartels
commented
Jul 6, 2025
Contributor
Can you show some other projects that use this same strategy? |
ContributorAuthor
The official postgres image uses template rendering, although not with |
kpalang
commented
Jul 14, 2025
ContributorAuthor
Adding this to leave a trace behind, good conversation going on in this thread in Discord. |
Closed
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds templating capabilities to render a
Dockerfileand an accompanyingcompose.yamlfor each OIE release.To render the files ensure you have installed
gomplate. Then run the./render_docker_images.shscript from repository root.To build the images, run the following command from repo root, replacing the
4.5.2-tp.1with your desired version number.docker compose -f dockerfiles/4.5.2-tp.1/compose.yaml build --build-arg CREATED_AT=$(date -u +"%Y-%m-%dT%H:%M:%SZ")