Uh oh!
There was an error while loading. Please reload this page.
Replaced SimpleDateFormat with DateTimeFormatter wherever thread-critical - #208
Merged
tonygermano merged 1 commit intoNov 29, 2025
Conversation
mgaffigan
requested changes
Nov 19, 2025
mgaffigan
left a comment
Contributor
There was a problem hiding this comment.
I agree with changing:
- server/src/com/mirth/connect/client/core/api/providers/CalendarParamConverterProvider.java
- server/src/com/mirth/connect/plugins/serverlog/ServerLogItem.java
but the others are all allocated on the stack - and have no possibility for cross-thread use. Changing DateUtil in particular seems unnecessarily risky.
Also, is there a reason we're jumping to Apache FastDateFormat instead of Java 8 DateTimeFormatter?
NicoPielforce-pushed
the
bug/replace-simpledateformat
branch
from
November 20, 2025 00:18
9b1257e to
614b02eCompareNicoPielforce-pushed
the
bug/replace-simpledateformat
branch
from
November 20, 2025 14:15
2ce92e1 to
75644deComparejonbartels
commented
Nov 21, 2025
Contributor
I agree with Mitch
The core Java DateTimeFormatter is rock solid. |
NicoPiel
commented
Nov 21, 2025
ContributorAuthor
That's why it's implemented :) |
NicoPiel
commented
Nov 24, 2025
ContributorAuthor
@mgaffigan Any more thoughts on this? |
jonbartels
previously approved these changes
Nov 24, 2025
mgaffigan
requested changes
Nov 24, 2025
mgaffigan
left a comment
Contributor
There was a problem hiding this comment.
Please omit the unused import, then I'll be good.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
NicoPiel
commented
Nov 24, 2025
ContributorAuthor
Done. |
mgaffigan
previously approved these changes
Nov 24, 2025
NicoPielforce-pushed
the
bug/replace-simpledateformat
branch
from
November 24, 2025 18:59
5fc7fb6 to
d2b3e14Comparejonbartels
previously approved these changes
Nov 24, 2025
Uh oh!
There was an error while loading. Please reload this page.
mgaffigan
previously approved these changes
Nov 25, 2025
tonygermano
previously approved these changes
Nov 25, 2025
kayyagari
self-requested a review
November 26, 2025 04:19
kayyagari
previously approved these changes
Nov 26, 2025
NicoPiel
dismissed stale reviews from kayyagari, tonygermano, and mgaffigan
via
November 26, 2025 15:21
f91ae66kayyagari
self-requested a review
November 26, 2025 16:12
kayyagari
previously approved these changes
Nov 26, 2025
mgaffigan
previously approved these changes
Nov 26, 2025
NicoPielforce-pushed
the
bug/replace-simpledateformat
branch
3 times, most recently
from
November 28, 2025 15:29
c2f5445 to
a9aae13CompareNicoPielforce-pushed
the
bug/replace-simpledateformat
branch
from
November 28, 2025 15:30
a9aae13 to
a0fc467CompareReplace usages of the non-thread-safe date formatter with java.time's DateTimeFormatter and related APIs to improve thread-safety and correctness when parsing/formatting dates and time zones. Update calendar parameter conversion to use ZonedDateTime/Instant and adapt log timestamp formatting to use DateTimeFormatter. Removes unused imports and modernizes date handling to avoid concurrency issues introduced by SimpleDateFormat. Collectively decided to use `DateTimeFormatter` instead of `FastDateTime`. Signed-off-by: Nico Piel <nico.piel@hotmail.de>
NicoPielforce-pushed
the
bug/replace-simpledateformat
branch
from
November 28, 2025 15:31
a0fc467 to
fa8957dComparetonygermano
approved these changes
Nov 28, 2025
mgaffigan
approved these changes
Nov 29, 2025
jonbartels
approved these changes
Nov 29, 2025
kayyagari
self-requested a review
November 29, 2025 03:09
kayyagari
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #207