Skip to content

fix: migrate legacy dir.logs log4j property - #275

Merged
mgaffigan merged 2 commits into
OpenIntegrationEngine:mainfrom
mgaffigan:copilot/fix-log4j2-properties-invalid-line
Mar 31, 2026
Merged

fix: migrate legacy dir.logs log4j property#275
mgaffigan merged 2 commits into
OpenIntegrationEngine:mainfrom
mgaffigan:copilot/fix-log4j2-properties-invalid-line

Conversation

@mgaffigan

Copy link
Copy Markdown
Contributor

Fixes a crash on boot caused by dir.logs set in log4j2.properties, which is not supported in log4j2. Cannot use normal migration infra since log4j is initialized early in the boot processs (before classpath is fully set up).

Closes#267

@mgaffigan
mgaffiganforce-pushed the copilot/fix-log4j2-properties-invalid-line branch 4 times, most recently from bbf0117 to 71a5c24CompareMarch 27, 2026 17:37
@mgaffigan
mgaffiganforce-pushed the copilot/fix-log4j2-properties-invalid-line branch from 71a5c24 to d17ee13CompareMarch 27, 2026 17:42
@mgaffigan
mgaffigan marked this pull request as ready for review March 27, 2026 17:44
@mgaffigan
mgaffigan requested review from a team, NicoPiel, gibson9583, jonbartels, kayyagari, kpalang, ssrowe and tonygermano and removed request for a teamMarch 27, 2026 17:44
@github-actions

github-actionsBot commented Mar 27, 2026

Copy link
Copy Markdown

Test Results

111 files +1 214 suites +2 7m 46s ⏱️ + 2m 0s
654 tests +4 654 ✅ +4 0 💤 ±0 0 ❌ ±0 
1 308 runs +8 1 308 ✅ +8 0 💤 ±0 0 ❌ ±0 

Results for commit cf6f4d5. ± Comparison against base commit 59674d0.

♻️ This comment has been updated with latest results.

CopilotAIand others added 2 commits March 31, 2026 11:55
Fixes a crash on boot caused by dir.logs set in log4j2.properties, which
is not supported in log4j2. Cannot use normal migration infra since
log4j is initialized early in the boot processs (before classpath is
fully set up).
Issue: OpenIntegrationEngine#267
Signed-off-by: Mitch Gaffigan <mgaffigan@users.noreply.github.com>
Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
@mgaffigan
mgaffiganforce-pushed the copilot/fix-log4j2-properties-invalid-line branch from d17ee13 to cf6f4d5CompareMarch 31, 2026 16:55
@mgaffigan
mgaffigan merged commit a6ae879 into OpenIntegrationEngine:mainMar 31, 2026
4 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] log4j2.properties invalid line causing server startup failure

5 participants

@mgaffigan@kayyagari@jonbartels@NicoPiel