Uh oh!
There was an error while loading. Please reload this page.
Fix: bug in JXTreeTable.getEditingRow - #285
Merged
tonygermano merged 1 commit intoApr 9, 2026
Merged
Conversation
org.jdesktop.swingx.JXTreeTable contains the following (decompiled) methods
public boolean isHierarchical(int column) {
if (column >= 0 && column < this.getColumnCount()) {
return this.getHierarchicalColumn() == column;
} else {
throw new IllegalArgumentException("column must be valid, was" + column);
}
}
public int getEditingRow() {
if (this.editingRow == -1) {
return -1;
} else {
return this.isHierarchical(this.editingColumn) ? -1 : this.editingRow;
}
}
Exceptions are thrown, especially on macOS clients, when getEditingRow
is called while not editing, causing isHeirarchical to be called when
editingColumn is -1.
This commit overrides getEditingRow to protect against that condition.
Issue: OpenIntegrationEngine#272
Signed-off-by: Tony Germano <tony@germano.name>tonygermanoforce-pushed
the
fix/jxtreetable-bug
branch
from
April 4, 2026 15:59
27521dd to
be058f6Comparemgaffigan
approved these changes
Apr 5, 2026
tonygermano
requested review from
a team, NicoPiel, gibson9583, jonbartels, kayyagari, pacmano1 and ssrowe
and removed request for
a teamApril 7, 2026 22:10
jonbartels
approved these changes
Apr 8, 2026
jonbartels
left a comment
Contributor
There was a problem hiding this comment.
LGTM I no longer see the column error in the console when launching OIE from this branch
gibson9583
approved these changes
Apr 9, 2026
kryskool
approved these changes
Apr 9, 2026
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org.jdesktop.swingx.JXTreeTable contains the following (decompiled) methods
Exceptions are thrown, especially on macOS clients, when getEditingRow is called while not editing, causing isHeirarchical to be called when editingColumn is -1.
This commit overrides getEditingRow to protect against that condition.
Fixes#272
Several issues with similar stack traces have been logged against Mirth and Bridgelink over the past few years.