Fix silent message corruption from absent/blank channel scripts (#344)

[e210]

Fixes the root cause behind #344: POST /api/channels accepts a channel without <preprocessingScript>; the channel deploys "healthy" but corrupts every message to the literal string undefined on the wire.

Root cause

Two independent defects in JavaScriptUtil (full analysis in #344):

1. JavaScriptBuilder.generateScript string-concatenates a null script into the JS wrapper, producing function doScript() { null }. compileAndAddScript caches it as a "custom" preprocessor because its body differs from the default script.
2. executePreprocessorScripts guards results with result != null, but Rhino's Undefined is not Java null — Context.jsToJava coerces it to the string "undefined", which becomes the processed raw and flows to every destination.

Changes

• compileAndAddScript: a null/blank script is now treated as absent — evict from the compiled-script cache and return false (all callers already handle false as "no script").
• executePreprocessorScripts: both result checks (global + channel) now ignore Undefined, the same idiom getPostprocessorResponse already uses.
• New JavaScriptUtilTest: 5 tests exercising the real Rhino path (TDD — each fix developed against a failing test).

Behavior change note

A user preprocessor with no return statement previously corrupted the message body to "undefined"; it now passes the message through unchanged. This is footgun-removal: returning the literal string "undefined" as content is never intentional (return ''; and return null; behave as before).

Verification

• Full :server:test suite green.
• E2E on the patched build (the issue's exact repro XML, MLLP sink logging raw bytes):

Channel variant	Bytes on the wire (before)	Bytes on the wire (after)
Issue's incomplete XML as-is	\x0bundefined\x1c\r	intact HL7 message

The broader ask in #344 — structural validation/normalization in POST /api/channels — is deliberately out of scope here; it deserves its own design discussion. This PR removes the data corruption.

[jonbartels]

Holding my review until I hear from the original issue reporter - https://discord.com/channels/943670759891554316/943670760461987862/1528943487163044094

Looks good at a glance, but I'll let the OP verify it first

[github-actions]

Test Results

663 tests +5 663 ✅ +5 2m 5s ⏱️ + 1m 1s
111 suites +1 0 💤 ±0 
111 files +1 0 ❌ ±0 

Results for commit 762e072. ± Comparison against base commit ac3a398.

♻️ This comment has been updated with latest results.

[MichaelLeeHobbs]

Thanks for tracking this down — clean fix, and the root cause explains a symptom I couldn't (RAW channels corrupting too, since the preprocessor runs on the raw message before datatype handling). Nice test coverage on the real Rhino path.

[Copilot]

Pull request overview

Fixes silent message corruption caused by absent/blank channel preprocessor scripts by ensuring such scripts aren’t cached/treated as custom, and by preventing Rhino Undefined results from being coerced into the literal "undefined" message payload.

Changes:

• Update preprocessor execution to ignore Rhino Undefined return values for both global and channel preprocessors.
• Update compileAndAddScript to treat null/blank preprocessor scripts as absent (cache eviction + no compile).
• Add Rhino-path unit tests covering null/blank script compilation behavior and Undefined handling.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
server/src/main/java/com/mirth/connect/server/util/javascript/JavaScriptUtil.java	Prevents Undefined from corrupting messages and adjusts script compilation/caching behavior for absent scripts.
server/src/test/java/com/mirth/connect/server/util/javascript/JavaScriptUtilTest.java	Adds tests to reproduce/guard the null/blank script + Undefined scenarios using real Rhino execution paths.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[e210]

Checked both Copilot notes:

Test mocks: Mockito's default returns empty collections, not null — so no NPE, the loops just no-op. The 659 green tests in CI agree.

Blank scripts (DatabaseReceiverScript): fair, but tiny: a blank select script is an already-broken channel (the Administrator won't save it). Before it failed every poll with DatabaseReceiverException("…: undefined"), now with an NPE from the same throw line, caught by the same catch. Happy to add a null-guard to that error message in a follow-up if wanted.

[tonygermano]

See inline comments. Also, please respond to the co-pilot suggestions.