Skip to content

#7 Updated signing certificate - #8

Merged
kpalang merged 2 commits into
mainfrom
feature/#7_keystore_update
Apr 1, 2025
Merged

#7 Updated signing certificate#8
kpalang merged 2 commits into
mainfrom
feature/#7_keystore_update

Conversation

@kpalang

@kpalangkpalang commented Mar 31, 2025

Copy link
Copy Markdown
Contributor

A new signing certificate is created with the exact same credentials as before, but now is 4096-bit RSA.

Closes#7

@kpalang
kpalang requested a review from gibson9583March 31, 2025 17:01
@kpalangkpalang self-assigned this Mar 31, 2025
@gibson9583

Copy link
Copy Markdown
Contributor

will we be undertaking any further branding/name changes for the initial/MVP? this updated entry is still called mirthconnect

@kpalang

Copy link
Copy Markdown
ContributorAuthor

Good point. I think for the default/white-labeled build an alias of openintegrationengine should be fine. We definitely should write documentation on how to swap out the signing certificate. I've created a ticket for this here.

Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
Signed-off-by: Kaur Palang <kaur.palang@brightcodecompany.com>
@kpalang
kpalangforce-pushed the feature/#7_keystore_update branch from 679e6aa to b21b8f5CompareMarch 31, 2025 18:10
@tonygermano

Copy link
Copy Markdown
Member

We probably need to have a talk about line endings, but for now I would err on the side of using the same line endings already in use in the file when you make a change (windows in this case.)

@kpalang

Copy link
Copy Markdown
ContributorAuthor

@tonygermano Good point. It may not be worth it to change for this commit, but we should implement .editorconfig in the future to maintain original line-endings.

@kpalang
kpalang merged commit 1ecd2d3 into mainApr 1, 2025
@kpalang
kpalang deleted the feature/#7_keystore_update branch April 1, 2025 21:12
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Current signing certificate is expired and a new one should be created

4 participants

@kpalang@gibson9583@tonygermano@jonbartels