Uh oh!
There was an error while loading. Please reload this page.
Issue #78 update PG drivers - #85
Conversation
tonygermano
commented
May 12, 2025
I think I would not bother updating the driver for simplesender. I didn't even realize what that code did until I looked at it. It hasn't been touched in 13 years. That library was added 18 years ago. My best guess is that it was part of some undocumented test process. I don't believe it was included in the mirth distributions, and it doesn't look like it even gets built as part of the normal build process. We probably need to evaluate to see if we want to get rid of it, and if we decide to keep it with the existing postgres functionality, it should be using a modern driver. |
jonbartels
left a comment
There was a problem hiding this comment.
Do not update the JARS in simplesender. They are not packaged in the OIE server or client.
jonbartels
commented
May 16, 2025
@tonygermano - I agree with you. I filed #88 |
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
pacmano1
commented
Oct 15, 2025
Ignore me asking CoPilot to review please. |
5c39642 to
2256d9fCompare39ac634 to
5bde40dComparejonbartels
commented
Dec 22, 2025
@jonbartels is picking this up again - We've likely let it sit so long the PG drivers are outdated. It definitely needs a rebase against main |
tonygermano
commented
Dec 23, 2025
I actually just rebased it less than 12 hours before you did, but the drivers are definitely outdated. |
5bde40d to
1ebc434CompareThere was a problem hiding this comment.
I rebased to main, took the latest pg jars from maven central.
I tested by merging a docker build from #101 and using the below compose file:
version: "3.1"services:
mc:
image: oie-devenvironment:
- DATABASE=postgres
- DATABASE_URL=jdbc:postgresql://db:5432/mirthdb
- DATABASE_MAX_CONNECTIONS=20
- DATABASE_USERNAME=mirthdb
- DATABASE_PASSWORD=mirthdb
- KEYSTORE_STOREPASS=docker_storepass
- KEYSTORE_KEYPASS=docker_keypass
- VMOPTIONS=-Xmx512mvolumes:
- ./data/volumes/appdata:/opt/connect/appdataports:
- 8080:8080/tcp
- 8443:8443/tcpdepends_on:
- dbdb:
image: postgresenvironment:
- POSTGRES_USER=mirthdb
- POSTGRES_PASSWORD=mirthdb
- POSTGRES_DB=mirthdbexpose:
- 5432built with docker build -t oie-dev ., started with docker-compose -f oie-pg.yml up and tested basic functionality (login, set password, create channel, deploy, send message, list results)
Signed-off-by: Richard Ogin <rogin@users.noreply.github.com> Signed-off-by: Tony Germano <tony@germano.name> Signed-off-by: Mitch Gaffigan <mitch.gaffigan@comcast.net>
1ebc434 to
8e1bf74Compare
kayyagari
left a comment
There was a problem hiding this comment.
I hope one day Gradle will help us get rid of multiple copies of these jars in the repo.
Uh oh!
There was an error while loading. Please reload this page.
edit: Version bumped to 42.7.8. Original PR description below.
Issue #78
Pulled latest v42.6.x from here. SHA1 hash verified. Sonatype showed it having zero vulnerabilities.
Could not find other PG jar at version "-405". Pulled latest "-408" version here. 2007 timestamp. SHA1 hash verified.
Code compiled w/exception of KeyEncryptorTest, which I deleted. All failed tests ignored.
Ignore the tool listing two renames - two files were deleted, and two files were added.