Skip to content

Install4j configuration - #95

Merged
tonygermano merged 1 commit into
mainfrom
feature/install4j-config-81
Jun 28, 2025
Merged

Install4j configuration#95
tonygermano merged 1 commit into
mainfrom
feature/install4j-config-81

Conversation

@kayyagari

@kayyagarikayyagari commented May 20, 2025

Copy link
Copy Markdown

I have commented out the line that included modules to make the binary start with Java8 by default(because our first release still targets Java8) , let me know if there are any objection to that.

@kayyagari

kayyagari commented May 20, 2025

Copy link
Copy Markdown
Author

The generated installers:

  1. Ask for admin privileges only on Windows OS
  2. Don't need admin privileges on macOS and Linux

jonbartels
jonbartels requested changes May 20, 2025
View reviewed changes
Comment threadserver/docs/LICENSE.txt
tonygermano
tonygermano requested changes May 22, 2025
View reviewed changes
Comment threadserver/basedir-includes/oieserver.vmoptions Outdated
Comment threadserver/basedir-includes/oieservice.vmoptions Outdated
Comment threadserver/docs/LICENSE.txt
Comment threadLICENSE Outdated
Comment threadtools/install4j/oie-installer-config.install4j Outdated
@kayyagari
kayyagariforce-pushed the feature/install4j-config-81 branch from 684bbb8 to 7247f5bCompareJune 2, 2025 14:17
@jonbartelsjonbartels added this to the Technical Preview 1 milestone Jun 5, 2025
@tonygermanotonygermano linked an issue Jun 11, 2025 that may be closed by this pull request
Create install4j installer for all platforms #81
Closed
@tonygermanotonygermano removed this from the Technical Preview 1 milestone Jun 11, 2025
@tonygermano
tonygermanoforce-pushed the feature/install4j-config-81 branch from 31822b8 to e3ccc72CompareJune 28, 2025 04:50
Kiran Ayyagari@pacmano1@tonygermano
Added install4j configuration file
75ca77c
Co-authored-by: Paul Coyne <44065187+pacmano1@users.noreply.github.com>
Signed-off-by: kayyagari <kiran@sereen.io>
Signed-off-by: Tony Germano <tony@germano.name>
Issue: #81
@tonygermano
tonygermanoforce-pushed the feature/install4j-config-81 branch from e3ccc72 to 75ca77cCompareJune 28, 2025 04:56
@tonygermano
tonygermano merged commit 75ca77c into mainJun 28, 2025
@tonygermano
tonygermano deleted the feature/install4j-config-81 branch June 28, 2025 19:25
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonbartelsjonbartelsjonbartels approved these changes
@tonygermanotonygermanotonygermano approved these changes
@pacmano1pacmano1pacmano1 approved these changes
@gibson9583gibson9583Awaiting requested review from gibson9583
@ssrowessroweAwaiting requested review from ssrowe
@kpalangkpalangAwaiting requested review from kpalang

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Create install4j installer for all platforms

4 participants

@kayyagari@jonbartels@tonygermano@pacmano1