Uh oh!
There was an error while loading. Please reload this page.
Support for VTN-to-VEN Reports - #174
Open
gthole wants to merge 6 commits into
Open
Conversation
Signed-off-by: Greg Thole <gthole@gmail.com>
gtholeforce-pushed
the
vtn-reporting-hooks
branch
from
November 14, 2024 14:59
1be2a69 to
3b285d6CompareSigned-off-by: Greg Thole <gthole@gmail.com>
Signed-off-by: Greg Thole <gthole@gmail.com>
axmsoftware
approved these changes
Nov 26, 2024
axmsoftware
left a comment
Contributor
There was a problem hiding this comment.
Implements a missing feature
axmsoftware
left a comment
Contributor
There was a problem hiding this comment.
Test failures need to be addressed before merge .See test-suite workflow for python 3.10
Included the new valid handlers in the testing, should consider adding test for each? Signed-off-by: Mohammed Ali <mohammed.binbasri@gmail.com>
considered the case when it is empty and no key for 'reports' is there. I think migrating to pydantic would be better Signed-off-by: Mohammed Ali <mohammed.binbasri@gmail.com>
Binbasri-in
approved these changes
Aug 3, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow clients to implement VTN-to-VEN reports with poll callback handlers.
Add callback handlers for
oadrRegisterReportandoadrUpdateReportPoll messages.Notes:
oadrRegisterReportwill still return anoadrRegisteredReportwith no requested reports as before, so there is no change to that behavior unless a VEN client adds a handler.oadrUpdateReportpreviously would crash the client since it would attempt to call an_on_reportmethod that does not exist on the Client class. Now it will return anoadrUpdatedReportto the VTN and call a handler.Many thanks for this excellent project!