Uh oh!
There was an error while loading. Please reload this page.
Refactor omc session classes - #250
Conversation
syntron
commented
Apr 15, 2025
based on #240 - cleanup of the remaining classes ... |
arun3688
commented
Apr 15, 2025
@syntron can you resolve the conflicts and update the PR |
* class OMCSessionBase only contains ask() and derived functions to call OM * the moved functions were using variables of class OMCSessionZMQ * this change splits the class definitions into (1) code to connect to OM => OMCSessionBase (2) code to execute OM / connect to running OM => OMCSessionZMQ
8f38d66 to
5bd67daComparesyntron
commented
Apr 16, 2025
Done |
adeas31
left a comment
There was a problem hiding this comment.
LGTM.
Maybe in another PR we can also remove OMCSessionBase as it doesn't serve any purpose now.
I could create such a commit; however, my proposal would be to only add some cleanup as the current structure quite nicely splits This way, it would be possible to keep OMCSessionZMQ clean. Furthermore, it could allow to split it into code which is needed to run OM locally and the code which is related to docker based execution. I expect, that the docker case would be something which could run on top of the local execution. |
merge OMCSessionHelper into OMCSessionZMQ
define execute as deprecated
merge (parts of) OMCSessionBase into OMCSessionZMQ
(1) code to connect to OM => OMCSessionBase
(2) code to execute OM / connect to running OM => OMCSessionZMQ