Uh oh!
There was an error while loading. Please reload this page.
Refactor file structure - #257
Merged
Merged
Conversation
syntronforce-pushed
the
refactor_file_structure
branch
from
April 17, 2025 17:11
2c6ce23 to
5fc1d97Compare Merged
adeas31
commented
Apr 23, 2025
Member
@syntron please fix conflicts. |
ContributorAuthor
syntronforce-pushed
the
refactor_file_structure
branch
from
April 23, 2025 17:29
5fc1d97 to
742ed1cComparesyntron
commented
Apr 23, 2025
ContributorAuthor
rebase available |
Closed
adeas31
commented
Apr 23, 2025
Member
reason: cleanup; no need to use a sub-module / sub-directory
* dummy entries for the classes to move from __init__.py
* dummy entries for the classes to move from __init__.py
* fix imports based on merged changes
!! only copy & paste of the class definitions - *NO* further change !! * OMCSessionBase => OMCSession.py * OMCSessionZMQ => OMCSession.py * ModelicaSystem => ModelicaSystem.py * ModelicaSystemError => ModelicaSystem.py
syntronforce-pushed
the
refactor_file_structure
branch
from
April 24, 2025 18:24
742ed1c to
5e0569cComparesyntron
commented
Apr 24, 2025
ContributorAuthor
rebased again; ready for merge! |
adeas31
self-requested a review
April 25, 2025 11:21
adeas31
approved these changes
Apr 25, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
See #254
Purpose
Separate the differnet classes / parser files such that specific commits touch only the corresponding file.
Use init.py only for the package related definitions (public interface of the package)
Approach
This is splitted into several commits such that the main change (move class definitions) can easily be rebased / redone
There are some smaller changes which I would add on top of this change / after #249