Skip to content

Fix two spaces in simflags causing silent error - #264

Merged
arun3688 merged 3 commits into
OpenModelica:masterfrom
ondras12345:invalid-command-line-option
Apr 29, 2025
Merged

Fix two spaces in simflags causing silent error#264
arun3688 merged 3 commits into
OpenModelica:masterfrom
ondras12345:invalid-command-line-option

Conversation

@ondras12345

Copy link
Copy Markdown
Contributor

No description provided.

Otherwise, it could fail silently (e.g. invalid command line option
error is only printed to stdout and not stderr).

@syntronsyntron left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noted this change - it overlaps with #273 and perhaps should merged together

@ondras12345

Copy link
Copy Markdown
ContributorAuthor

Good idea. Feel free to cherry-pick the first commit into your pull request. The second one is redundant. Ping me after you've done that and I will close this PR.

@syntron

Copy link
Copy Markdown
Contributor

@ondras12345 will do a cherry-pick; currently more changes to _run_cmd() are planned

@arun3688
arun3688 merged commit 5b21a06 into OpenModelica:masterApr 29, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@ondras12345@syntron@arun3688