Skip to content

Omc port from log - #301

Merged
adeas31 merged 2 commits into
OpenModelica:masterfrom
syntron:OMC_port_from_log
Jun 23, 2025
Merged

Omc port from log#301
adeas31 merged 2 commits into
OpenModelica:masterfrom
syntron:OMC_port_from_log

Conversation

@syntron

Copy link
Copy Markdown
Contributor

OMC writes the ZMQ port into a file which must be found to get this information. Currently OMPython defines the file name in the Python code. However, this information is available in the log of OMC - why not use it?

This code replaces the old way of defining the port file with an evaluation of the log data.

Based on top of PR #295; this should be included in the next release (see #254)

@syntron
syntronforce-pushed the OMC_port_from_log branch 2 times, most recently from 30449bd to 9724775CompareJune 13, 2025 19:53
This was referenced Jun 16, 2025
@adeas31adeas31 added this to the 4.0.0 milestone Jun 18, 2025
@adeas31

Copy link
Copy Markdown
Member

@syntron this needs to be rebased before we can review it properly. Seems like the actual change is in commit which looks fine to me. I looked into the compiler code and indeed the log contains the file path and we don't need to construct it.

@adeas31
adeas31 merged commit f9bfcf6 into OpenModelica:masterJun 23, 2025
@syntron
syntron deleted the OMC_port_from_log branch June 23, 2025 17:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@syntron@adeas31