Skip to content

OMCPath - #317

Merged
adeas31 merged 33 commits into
OpenModelica:masterfrom
syntron:OMCPath
Oct 20, 2025
Merged

OMCPath#317
adeas31 merged 33 commits into
OpenModelica:masterfrom
syntron:OMCPath

Conversation

@syntron

@syntronsyntron commented Jun 28, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

new class OMCPath which implements path handling based on OMC commands

currently just a prove of concept with a test case using docker

see issue #315 and PR #309

Important: due to limitations in pathlib.Path, this is not working for Python < 3.12! - I'm testing compatibility but got no overall success (local Linux seems to work / Windows fails for 3.10)

@syntron
syntronforce-pushed the OMCPath branch 4 times, most recently from 7514c47 to 13fec2cCompareJuly 9, 2025 18:35
@syntron
syntronforce-pushed the OMCPath branch 2 times, most recently from c8bddac to b59e473CompareJuly 11, 2025 19:30
@syntronsyntron mentioned this pull request Jul 11, 2025
Merged
@syntron
syntronforce-pushed the OMCPath branch 4 times, most recently from 1b64550 to c45b4f7CompareJuly 11, 2025 21:10
@syntronsyntron mentioned this pull request Jul 11, 2025
Merged
@syntron

syntron commented Jul 12, 2025•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@Sonyoyo could you please test if this is working on WSL and provide some feedback? I'm just coding blind regarding this option ...

Feel free to use the testcase in tests.test_OMCPath.test_OMCPath_WSL() - it is working well on local and docker; thus, should also work on WSL (I hope)

@syntron

syntron commented Jul 12, 2025

Copy link
Copy Markdown
ContributorAuthor

@ondras12345 could you please advice on the unittest?

In tests.test_OMCPath tests are defined which use different backends (local / docker / WSL). I implemented it by using different functions to define the test and the unique code is in a helper function which is called by each test.

@syntronsyntron mentioned this pull request Jul 12, 2025
Closed
@syntron
syntron marked this pull request as ready for review August 12, 2025 20:25
@adeas31adeas31 added this to the 4.1.0 milestone Aug 18, 2025
@syntron
[OMCPath] add warning message for Python < 3.12
84c73be
@syntron
[OMCPath] try to make mypy happy ...
3fa97b0
@syntron
[test_OMCPath] only for Python >= 3.12
84c7671
@syntron
[test_OMCPath] update test
f256888
@syntron
[OMCPath._omc_resolve] use sendExpression() with parsed=False
458b875
* this is scripting output and, thus, it cannot be parsed
@syntron
[test_OMCPath] cleanup; use the same code for local OMC and docker ba…
9a16d44
…sed OMC
@syntron
[test_OMCPath] define test for WSL
0ea522e
@syntron
[test_OMCPath] use omcpath_tempdir() instead of hard-coded tempdir de…
0a67b35
…finition
@syntron
[OMCPath] spelling fix
7f86ff6
see commit ID: aa74b36 - [OMCPath] add more functionality and docstrings
@syntron
[OMCPath] implementation version 3
f2cd718
* differentiate between
* Python >= 3.12 uses OMCPath based on OMC for filesystem operation
* Python < 3.12 uses a pathlib.Path based implementation which is
limited to OMCProcessLocal
@syntron
[OMCSession*] fix flake8 (PyCharm likes the empty lines)
63042fb
@syntron
[OMCSessionZMQ] more generic definiton for omcpath_tempdir()
6328a17
@syntron
[OMCPathCompatibility] mypy on github ...
ad7d54f
@syntron
[OMCPathCompatibility] improve log messages
769bd67
@syntron
[test_OMCPath] update
553933a
@syntron
[OMCPathReal] align exists() to the definition used in pathlib
6629673
@syntron
[test_OMCPath] fix error
6f70ad2
error: "unlink" of "OMCPathReal" does not return a value (it only ever returns None) [func-returns-value]
adeas31
adeas31 reviewed Oct 20, 2025
View reviewed changes

@adeas31adeas31 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Important: due to limitations in pathlib.Path, this is not working for Python < 3.12! - I'm testing compatibility but got no overall success (local Linux seems to work / Windows fails for 3.10)

Did you figure out what is the limitation? Is there a workaround?

Comment threadOMPython/OMCSession.py
@syntron

syntron commented Oct 20, 2025

Copy link
Copy Markdown
ContributorAuthor

Did you figure out what is the limitation? Is there a workaround?

see 1acd916: there is a compatibility layer such that for Python < 3.12 pathlib.Path is used such that it will work on the same level as it is now (i.e. no regression but also not the new possibilities)

@adeas31
adeas31 merged commit 07eb621 into OpenModelica:masterOct 20, 2025
14 checks passed
@syntron
syntron deleted the OMCPath branch October 26, 2025 19:55
This was referenced Oct 30, 2025
Closed
Merged
@adeas31adeas31 mentioned this pull request Nov 5, 2025
Closed
@syntronsyntron mentioned this pull request Dec 2, 2025
Merged
@adeas31adeas31 modified the milestones: 4.1.0, 5.0.0Dec 16, 2025
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adeas31adeas31adeas31 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

2 participants

@syntron@adeas31