Uh oh!
There was an error while loading. Please reload this page.
(A013) [ModelicaSystemDoE] simplify definition - #423
Conversation
10db374 to
3c62d45Compare[ModelicaSystemDoE] simplify definition; use a Modelicasystem instance as argument [ModelicaSystemDoE] update docstring [ModelicaSystemDoE] fix for relative paths [ModelicaSystemDoE] fix unittest * test_ModelicaSystemDoE_local is tested * test_ModelicaSystemDoE_docker should work * test_ModelicaSystemDoE_WSL is untested
3c62d45 to
7e8b418Compare| tmpdir = tmp_path / 'DoE' | ||
| tmpdir.mkdir(exist_ok=True) | ||
| omcs = OMPython.OMCSessionWSL() | ||
| assert omcs.sendExpression("getVersion()") == "OpenModelica 1.25.0" |
There was a problem hiding this comment.
I know this will not run on GitHub tests but still what is the point of checking against hard coded version?
There was a problem hiding this comment.
The idea is to ensure within the test definition directly after the setup that OMC is running; the check could be removed ...
There was a problem hiding this comment.
Rather than validating against a specific version, we can check whether getVersion() returns a non-empty result to ensure that OMC is functioning correctly.
There was a problem hiding this comment.
OK - updated version which checks for str and startwith('OpenModelica') for all usecases
…s a (gerneric) OpenModelica version string
Uh oh!
There was an error while loading. Please reload this page.
see PR #404