(A015) [ModelicaSystem] check model executable

[syntron]

define one fucntion to check if the model executable exists and is working

see PR #404

[adeas31]

Rebase.

[syntron]

Rebase.

can but why is it needed? It is PR = one commit; should apply without problems?!

[adeas31]

Rebase.

can but why is it needed? It is PR = one commit; should apply without problems?!

It says,

This branch has conflicts that must be resolved
Use the web editor or the command line to resolve conflicts before continuing.

OMPython/ModelicaSystem.py

[syntron]

Rebase.

can but why is it needed? It is PR = one commit; should apply without problems?!

It says,

This branch has conflicts that must be resolved Use the web editor or the command line to resolve conflicts before continuing.

OMPython/ModelicaSystem.py

Interesting - I did the rebase and there is no diff between the two version:

There isn’t anything to compare.
6c794cba710abd55550d8c1311b45b2b7b5327bb and e5c8a4170b685b02fa45dbb323fc9271d605d879 are identical.

[adeas31]

Would be nice to have a test for this function.

It is highly unlikely that we change model executable to not have a help command line option but just in case it would be nice to have a test for it. What do you think?

[syntron]

Would be nice to have a test for this function.

It is highly unlikely that we change model executable to not have a help command line option but just in case it would be nice to have a test for it. What do you think?

It is possible to create a separate unittests - however, each simulation request done in test_ModelicaSystem calls into this functions. Thus it is tested!

Regarding a separate unittest: what should be tested? (1)a separate test if the function runs without error (=> each simulation) or (2) if the option exist (=> only possible via the execution with --help => back to simulation => point(1) )

[adeas31]

Would be nice to have a test for this function.
It is highly unlikely that we change model executable to not have a help command line option but just in case it would be nice to have a test for it. What do you think?

It is possible to create a separate unittests - however, each simulation request done in test_ModelicaSystem calls into this functions. Thus it is tested!

Then it is fine.