Skip to content

B001 ModelicaSystem split - #426

Merged
adeas31 merged 2 commits into
OpenModelica:masterfrom
syntron:B001-ModelicaSystem_split
Apr 14, 2026
Merged

B001 ModelicaSystem split#426
adeas31 merged 2 commits into
OpenModelica:masterfrom
syntron:B001-ModelicaSystem_split

Conversation

@syntron

Copy link
Copy Markdown
Contributor

(B001) split ModelicaSystem

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem
[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC
* add compatibility variable for ModelicaSystem
[test_ModelicaSystemOMC] rename from ModelicaSystem and update
[test_*] use ModelicaSystemOMC
[ModelicaSystem*] fix last usages of ModelicaSystem() in comments & docstrings

@syntronsyntron changed the title B001 modelica system splitB001 ModelicaSystem splitFeb 27, 2026
@syntron
syntronforce-pushed the B001-ModelicaSystem_split branch 2 times, most recently from 59e6c9d to 946a091CompareMarch 13, 2026 17:11
@adeas31

Copy link
Copy Markdown
Member

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

We could do ModelicaSystemBase instead of ModelicaSystemABC and ModelicaSystem instead of ModelicaSystemOMC. This requires less changes both in the code base and for the users.

@syntron

Copy link
Copy Markdown
ContributorAuthor

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem

[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC

We could do ModelicaSystemBase instead of ModelicaSystemABC and ModelicaSystem instead of ModelicaSystemOMC. This requires less changes both in the code base and for the users.

This is done on purpose; a later change (PR #437) creates a compatibility layer => ModelicaSystem is used there.

*ABC is used to indicate an uncomplete class => there are functions missing which are just added in the derived classes *OMC or *Runner. This is handled for ModelicaSystem*, OM(C)Session* and Modelica(System)DoE*. See PR #441, PR #442 and PR #443.

@syntron
syntronforce-pushed the B001-ModelicaSystem_split branch from 946a091 to 46eb63dCompareMarch 18, 2026 18:38
@adeas31

Copy link
Copy Markdown
Member

Resolve conflicts.

[ModelicaSystem] split ModelicaSystem into ModelicaSystemABC and ModelicaSystem
[ModelicaSystem] rename ModelicaSystem => ModelicaSystemOMC
* add compatibility variable for ModelicaSystem
[test_ModelicaSystemOMC] rename from ModelicaSystem and update
[test_*] use ModelicaSystemOMC
[ModelicaSystem*] fix last usages of ModelicaSystem() in comments & docstrings
@syntron
syntronforce-pushed the B001-ModelicaSystem_split branch from 46eb63d to d9f705aCompareApril 1, 2026 20:33
@syntron

Copy link
Copy Markdown
ContributorAuthor

Resolve conflicts.

@adeas31 Done ...

@syntron

Copy link
Copy Markdown
ContributorAuthor

@adeas31 anything I can do here? the pull request is fine - it is just a timeout for Windows build ...

@adeas31
adeas31 merged commit e766959 into OpenModelica:masterApr 14, 2026
10 checks passed
@syntron
syntron deleted the B001-ModelicaSystem_split branch April 14, 2026 16:42
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@syntron@adeas31