Skip to content

D005 OMCSession - classes update - #435

Merged
adeas31 merged 6 commits into
OpenModelica:masterfrom
syntron:D005-OMCSession_classes_update
Apr 29, 2026
Merged

D005 OMCSession - classes update#435
adeas31 merged 6 commits into
OpenModelica:masterfrom
syntron:D005-OMCSession_classes_update

Conversation

@syntron

Copy link
Copy Markdown
Contributor

(D005) update classes in OMCSession

[OMCSessionPort] fix timeout handling
[OMCSessionDocker*] improve data handling
* move more code to OMCSessionDockerHelper
* use _docker_omc_start() to differentiate classes
* define cmd_prefix
[OMCSessionWSL] define cmd_prefix
[OMCSessionWSL] layout fix

[(_)OMPathRunnerLocal] improve definition
* fix return values
* additional cleanups
[__init__] define OMPathRunnerLocal for public interface
[_OMPathRunnerBash] define class
[__init__] define OMPathRunnerBash for public interface
[OMSessionRunner] update code such that it can be used by OMPathRunnerLocal and OMPathRunner Bash
[OMCSessionPort] fix timeout handling
[OMCSessionDocker*] improve data handling
* move more code to OMCSessionDockerHelper
* use _docker_omc_start() to differentiate classes
* define cmd_prefix
[OMCSessionWSL] define cmd_prefix
[OMCSessionWSL] layout fix
@syntron
syntronforce-pushed the D005-OMCSession_classes_update branch from 8361414 to 684d32cCompareApril 21, 2026 20:08
Comment threadOMPython/OMCSession.py Outdated
@syntronsyntron mentioned this pull request Apr 29, 2026
@syntron
syntronforce-pushed the D005-OMCSession_classes_update branch from 7246c36 to 8ff6d18CompareApril 29, 2026 17:29
* definition in OMSessionABC
* move `set_timeout()` to this class
* all other places use `timeout: Optional[float] = None`
@syntron
syntronforce-pushed the D005-OMCSession_classes_update branch from 8ff6d18 to 39139e0CompareApril 29, 2026 17:31
@syntron
syntronforce-pushed the D005-OMCSession_classes_update branch from 0b8cf5a to b6ec039CompareApril 29, 2026 17:40
@adeas31
adeas31 merged commit 11ecd58 into OpenModelica:masterApr 29, 2026
10 checks passed
@syntron
syntron deleted the D005-OMCSession_classes_update branch April 30, 2026 20:09
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@syntron@adeas31