Uh oh!
There was an error while loading. Please reload this page.
Fix Building Guide on servers - #826
Conversation
Oh my, this is going to be tricky...
|
Eufranio
commented
Jun 17, 2017
This is not less functional, I've opened this PR just to replace your method with another one that works, and fire events (just like any other mod should fire). This shouldn't have nothing to do with Bukkit/Cauldron/Thermos/whatever, it's just a simple method, it won't change anything in the gameplay, so how am I supposed to make a config option? |
Eufranio
commented
Jun 17, 2017
boq
commented
Jun 17, 2017
Ah, I was talking about dropping player information, but I misread that part. Though you don't restore snapshot on cancelled event. Also, if it's related to #755, what environments have you tested? |
Eufranio
commented
Jun 17, 2017
Since I can't compile the code, I couldn't test, I was about to open an issue about the error but you're here now, so... |
boq
commented
Jun 17, 2017
Can't help with Idea (always used Eclipse). Though we are not doing anything special other than subproject for OpenModsLib (which should be supported, since it's standard Gradle feature). |
Eufranio
commented
Jun 17, 2017
Eufranio
commented
Jun 17, 2017
I just needed a |
Eufranio
commented
Jun 17, 2017
It's now working, but I'm having some problems when the event is cancelled: the for loop will skip the protected block, but will still place it (not restoring)... |
Fixed, it's now respecting cancelled events, and working on Singleplayer/Mixed (Forge + Bukkit) servers. With this update, you could also make a release of OpenModsLib (the fix you pushed for /dev/null/ is only in OpenModsLib-1.7.10-0.10-snapshot-465, not in the official release as you fixed it later). |
Eufranio
commented
Jun 21, 2017
boq
commented
Jun 21, 2017
Please don't ping. I appreciate your work, but unless there is a world-breaking bug, I won't do any more 1.7 releases. Please wait for 1.10 merge. |


No description provided.