Uh oh!
There was an error while loading. Please reload this page.
Add Keychron Nape Pro layer remaps and per-layer orientation (rebased) - #37
Merged
Conversation
# Conflicts: # src/drivers/registry.ts
Combines the M6 PR (#33) and Nape Pro PR (#29), which both branched before the other landed and independently touched keychron/index.ts and registry.ts. Retires the generic KeychronHidClient (keychron/hid.ts): nape-hid.ts is a strict superset of it and both matched the exact same product IDs, so every Nape Pro device was claimable by two drivers (caught by registry.test.ts). This matches this PR's own stated intent ("keep the Keychron driver Nape-only"). Build and full test suite pass (544/544). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #29 onto main after #33 (Keychron M6) merged, with the resulting Keychron driver overlap resolved: the generic
KeychronHidClient(keychron/hid.ts) is retired sincenape-hid.tsis a strict superset of it and both matched the exact same product IDs — every Nape Pro device was claimable by two drivers, whichregistry.test.tscatches. This matches #29's own stated intent ("keep the Keychron driver Nape-only"). Build and full test suite pass (544/544).Closes#29.