Uh oh!
There was an error while loading. Please reload this page.
endgame: show a neutral OP1w/XM2w 4K v2 name instead of guessing wrong - #64
Merged
Merged
Conversation
Yesterday's fix assumed device.productName would carry the actual paired mouse's model. Confirmed on real hardware it doesn't: an XM2w 4K v2 reports productName as "Endgame Gear OP1we" — the receiver's fixed USB descriptor string, identical regardless of which mouse is paired. There is no "xm2" substring for the check to ever find. Checked for prior art: stuffz/mouse-battery-monitor documents this same shared dongle PID (0x1970) and states there is no known way to distinguish the model over the wire. Rather than confidently claim the wrong specific model, both PID entries now report a combined "Endgame Gear OP1w/XM2w 4K v2" name until a real signal turns up.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrects PR #61. That fix checked
device.productNamefor "xm2", assuming WebHID exposes the real paired-mouse name over the shared 0x1970/0x1984 dongle. Confirmed wrong on real hardware (screenshot from a user report): an XM2w 4K v2 showsproductNameas "Endgame Gear OP1we" — the receiver's fixed USB descriptor string, same regardless of which mouse is actually paired.Checked for prior art before re-guessing: stuffz/mouse-battery-monitor independently documents this same shared dongle PID and states outright there's no known way to distinguish the model over the wire. So rather than confidently claim the wrong specific model again, both PID entries now report "Endgame Gear OP1w/XM2w 4K v2" until a real signal is found (e.g. a captured EEPROM/config byte that varies between units).