Uh oh!
There was an error while loading. Please reload this page.
feat(keychron): claim the M6 with its own driver instead of Pulsar's (rebased) - #135
Merged
Conversation
The M6 driver in @openmouse/protocol is enough for the registry to detect the mouse, but not for the app to drive it: the sidebar lists it as "Keychron · Available" and activating it fails with client.describeCollections is not a function pulsarClient() is a negative check — any active client not listed in DEDICATED is assumed to be a Pulsar client and routed into showPulsarExplorer(), which calls describeCollections(), a method only the Pulsar drivers have. A new driver class is therefore broken by default until it is named here, and the error points nowhere near the cause. KeychronM6HidClient joins NEEDS_OPEN, next to the Nape Pro's KeychronHidClient: its open() is what attaches the input-report listener its query/reply exchanges depend on, and NEEDS_OPEN feeds DEDICATED, so one entry covers both. Verified on a wired Keychron M6: the device connects and reports 800 DPI, 500 Hz, and battery, and a DPI change flashes to the mouse and reads back. Needs the M6 driver from OpenMouse-Project/mouse-protocol#33.
Deploying openmouse with |
| Latest commit: | b150ae9 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f79eb089.openmouse.pages.dev |
| Branch Preview URL: | https://codex-keychron-m6-app-resolv.openmouse.pages.dev |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebase of #128 onto dev after the protocol bump (#132), resolving the Keychron import conflict: dev's controller.ts had already switched the generic
KeychronHidClientimport toKeychronNapeHidClient(aliased) since the protocol package retired the generic driver; this keeps that alias and adds this PR'sKeychronM6HidClientimport alongside it. Build, bundle-size check, and full test suite (84/84) pass.Closes#128.