Skip to content

Fix: Improve tab visibility on hover in dark theme - #139

Closed
shivom007 wants to merge 1 commit into
OpenMouse-Project:mainfrom
shivom007:fix/hover-property-for-dark-theme
Closed

Fix: Improve tab visibility on hover in dark theme#139
shivom007 wants to merge 1 commit into
OpenMouse-Project:mainfrom
shivom007:fix/hover-property-for-dark-theme

Conversation

@shivom007

Copy link
Copy Markdown
Contributor

Summary

This PR fixes an accessibility/UI issue in the dark theme where hovering over tabs (.ftab:hover) did not provide sufficient visual contrast.

Changes Made

  • Added a specific CSS rule for .ftab:hover under the [data-theme="dark"] selector in src/supported.css.
  • Hovering over a tab in dark mode will now cleanly invert to a white background with black text, matching expected UI feedback.

Before
image

After
image

How to Test

  1. Switch the application to the dark theme.
  2. Hover your mouse over any tab.
  3. Verify that the tab background turns white and the text turns black, making it clearly visible.

@snekxs

Copy link
Copy Markdown
Member

Closing as superseded — supported.css has since been fully rewritten onto CSS custom properties (--ink-*, --bg-hover, etc.) rather than the hardcoded [data-theme="dark"] hex overrides this PR patches (the .ftab/.spill-*/.search-input selectors this diff touches no longer exist). The tab/hover contrast issue this PR describes doesn't reproduce against current control-panel: filter option rows now use the theme-aware --bg-hover token. Thanks for the fix — sorry it didn't land before the rewrite passed it by!

@snekxssnekxs closed this Sep 6, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@shivom007@snekxs